fix(MQTT): Send first MapReport as soon as possible #8872
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throttle::isWithinTimespanMs(last_report_to_map, map_publish_interval_msecs) is used to maintain the map reporting interval, but because last_report_to_map has an initial value of 0, the map report routine does not start until the system millis() time has passed map_publish_interval_msecs. Fix this by adding a check that last_report_to_map is not 0. Signed-off-by: Andrew Yong <[email protected]>
Do not update last_report_to_map when Map Report is attempted without a valid location, as this results in waiting up to an hour (or configured Map Report interval). That usually happens because most nodes do not keep GPS warm, so GPS usually locks after the first attempt at Map Report. This change also results in the log WARNing message getting spammed until a location is obtained, so remove the message for now. Signed-off-by: Andrew Yong <[email protected]>
ndoo
force-pushed
the
mapreporting-fixes
branch
from
1b45418 to
c0ae01e
Compare
Contributor
Author
|
After discussion with Ixitxachitl on Discord, it looks like Map Reporting does get sent, but only after the millis() timer has passed the first interval. I can't think of any good reason not to send the first possible map report instead of letting the clock tick up to the first interval. So, keeping the code the same, but re-wording the PR and commit to match the actual fix (at least, how I perceive it). Please help to request re-review. |
ndoo
changed the title
fifieldt
approved these changes
Dec 6, 2025
Member
fifieldt
left a comment
fifieldt
left a comment
There was a problem hiding this comment.
This makes logical sense to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(MQTT): First MapReport does not get sent
Throttle::isWithinTimespanMs(last_report_to_map, map_publish_interval_msecs) is used to maintain the map reporting interval, but because last_report_to_map has an initial value of 0, the map report routine does not start until the system
millis() time has passed map_publish_interval_msecs.
Fix this by adding a check that last_report_to_map is not 0.
feat(MQTT): Send MapReporting immediately upon location fix
Do not update last_report_to_map when Map Report is attempted without a valid location, as this results in waiting up to an hour (or configured Map Report interval).
That usually happens because most nodes do not keep GPS warm, so GPS usually locks after the first attempt at Map Report.
This change also results in the log WARNing message getting spammed until a location is obtained, so remove the message for now.
🤝 Attestations