Skip to content

Commit c84380a

Browse files
author
marcel corso gonzalez
authored
Merge pull request #60 from Funfun/message-list-ext-filters
Extend Messagebird::Client#message_list args with any keys in it
2 parents 85767d7 + a60b053 commit c84380a

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

lib/messagebird/client.rb

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,10 @@ def message(id)
232232
end
233233

234234
# Retrieve messages with optional paging and status filter.
235-
def message_list(filter = {})
236-
limit = filter[:limit] || 10
237-
offset = filter[:offset] || 0
238-
status = filter[:status] || ''
239-
240-
params = { limit: limit, offset: offset }
241-
if status != ''
242-
params['status'] = status
243-
end
244-
query = 'messages?' + URI.encode_www_form(params)
235+
def message_list(filters = {})
236+
params = { limit: 10, offset: 0 }.merge(filters).compact
237+
query = "messages?#{URI.encode_www_form(params)}"
238+
245239
List.new(Message, request(:get, query))
246240
end
247241

0 commit comments

Comments
 (0)