: lint (#1694)

Summary:

lints in hyperactor, hyperactor mesh. i'm in a rush. i'll circle back to box the large errors - annotate for now.

Reviewed By: dulinriley

Differential Revision: D85793529

Author: shayne-fletcher

hyperactor/src/channel.rs

@@ -906,7 +906,6 @@ mod tests {
     use super::*;
     use crate::clock::Clock;
     use crate::clock::RealClock;
-    use crate::config;
 
     #[test]
     fn test_channel_addr() {

hyperactor/src/mailbox/undeliverable.rs

@@ -13,10 +13,8 @@ use serde::Serialize;
 use thiserror::Error;
 
 use crate as hyperactor; // for macros
-use crate::ActorId;
 use crate::Message;
 use crate::Named;
-use crate::PortId;
 use crate::actor::ActorStatus;
 use crate::id;
 use crate::mailbox::DeliveryError;

hyperactor_macros/src/lib.rs

@@ -1636,10 +1636,7 @@ impl syn::parse::Parse for BehaviorInput {
 /// ```
 #[proc_macro]
 pub fn behavior(input: TokenStream) -> TokenStream {
-    let BehaviorInput {
-        behavior: behavior,
-        handlers,
-    } = parse_macro_input!(input as BehaviorInput);
+    let BehaviorInput { behavior, handlers } = parse_macro_input!(input as BehaviorInput);
     let tys = HandlerSpec::add_indexed(handlers);
 
     let expanded = quote! {

hyperactor_mesh/Cargo.toml

@@ -65,7 +65,6 @@ libc = "0.2.139"
 mockall = "0.13.1"
 ndslice = { version = "0.0.0", path = "../ndslice" }
 nix = { version = "0.30.1", features = ["dir", "event", "hostname", "inotify", "ioctl", "mman", "mount", "net", "poll", "ptrace", "reboot", "resource", "sched", "signal", "term", "time", "user", "zerocopy"] }
-notify = "5"
 opentelemetry = "0.29"
 pin-project = "1.1.10"
 preempt_rwlock = { version = "0.0.0", path = "../preempt_rwlock" }

hyperactor_mesh/src/actor_mesh.rs

@@ -984,7 +984,7 @@ mod tests {
                     .await
                     .unwrap();
 
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 let proc_mesh = ProcMesh::allocate(alloc).await.unwrap();
                 let (undeliverable_tx, _undeliverable_rx) = proc_mesh.client().open_port();
                 let params = PingPongActorParams::new(Some(undeliverable_tx.bind()), None);
@@ -1030,7 +1030,7 @@ mod tests {
                     .await
                     .unwrap();
 
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 let proc_mesh = ProcMesh::allocate(alloc).await.unwrap();
                 let actor_mesh: RootActorMesh<TestActor> = proc_mesh.spawn(&instance, "echo", &()).await.unwrap();
                 let dont_simulate_error = true;
@@ -1074,7 +1074,7 @@ mod tests {
                     .await
                     .unwrap();
 
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 let proc_mesh = ProcMesh::allocate(alloc).await.unwrap();
                 let actor_mesh: RootActorMesh<TestActor> = proc_mesh.spawn(&instance, "echo", &()).await.unwrap();
 
@@ -1096,7 +1096,7 @@ mod tests {
             #[tokio::test]
             async fn test_inter_proc_mesh_comms() {
                 let mut meshes = Vec::new();
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 for _ in 0..2 {
                     let alloc = $allocator
                         .allocate(AllocSpec {
@@ -1157,7 +1157,7 @@ mod tests {
                     .await
                     .unwrap();
 
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 let mut proc_mesh = ProcMesh::allocate(alloc).await.unwrap();
 
                 let (tx, mut rx) = hyperactor::mailbox::open_port(proc_mesh.client());
@@ -1220,7 +1220,7 @@ mod tests {
                     .await
                     .unwrap();
 
-                let instance = crate::v1::testing::instance().await;
+                let instance = $crate::v1::testing::instance().await;
                 let mesh = ProcMesh::allocate(alloc).await.unwrap();
                 let (reply_port_handle, mut reply_port_receiver) = mesh.client().open_port::<usize>();
                 let reply_port = reply_port_handle.bind();

hyperactor_mesh/src/bootstrap.rs

@@ -257,11 +257,13 @@ pub enum Bootstrap {
 impl Bootstrap {
     /// Serialize the mode into a environment-variable-safe string by
     /// base64-encoding its JSON representation.
+    #[allow(clippy::result_large_err)]
     fn to_env_safe_string(&self) -> v1::Result<String> {
         Ok(BASE64_STANDARD.encode(serde_json::to_string(&self)?))
     }
 
     /// Deserialize the mode from the representation returned by [`to_env_safe_string`].
+    #[allow(clippy::result_large_err)]
     fn from_env_safe_string(str: &str) -> v1::Result<Self> {
         let data = BASE64_STANDARD.decode(str)?;
         let data = std::str::from_utf8(&data)?;

hyperactor_mesh/src/logging.rs

@@ -47,7 +47,6 @@ use hyperactor::data::Serialized;
 use hyperactor::declare_attrs;
 use hyperactor_telemetry::env;
 use hyperactor_telemetry::log_file_path;
-use notify::Watcher;
 use serde::Deserialize;
 use serde::Serialize;
 use tokio::io;
@@ -1657,12 +1656,14 @@ mod tests {
             "Expected deserialization to fail with invalid UTF-8 bytes"
         );
     }
+    #[allow(dead_code)]
     struct MockLogSender {
         log_sender: mpsc::UnboundedSender<(OutputTarget, String)>, // (output_target, content)
         flush_called: Arc<Mutex<bool>>,                            // Track if flush was called
     }
 
     impl MockLogSender {
+        #[allow(dead_code)]
         fn new(log_sender: mpsc::UnboundedSender<(OutputTarget, String)>) -> Self {
             Self {
                 log_sender,

hyperactor_mesh/src/logging/line_prefixing_writer.rs

@@ -27,6 +27,7 @@ where
     W: io::AsyncWrite + Unpin,
 {
     /// Creates a new LinePrefixingWriter that will prefix each line with "[<local_rank>] ".
+    #[allow(dead_code)]
     pub fn new(local_rank: usize, inner: W) -> Self {
         let prefix = format!("[{}] ", local_rank).into_bytes();
         Self {

hyperactor_mesh/src/proc_mesh.rs

@@ -697,6 +697,7 @@ impl ProcMesh {
                     .collect(),
                 actor_event_router: actor_event_router.clone(),
             }),
+            #[allow(clippy::todo)]
             ProcMeshKind::V1(_proc_mesh) => todo!(),
         }
     }

hyperactor_mesh/src/v1.rs

@@ -124,13 +124,13 @@ pub enum Error {
 
     #[error(
         "error spawning proc mesh: statuses: {}",
-        RankedValues::invert(&*.statuses)
+        RankedValues::invert(statuses)
     )]
     ProcSpawnError { statuses: RankedValues<Status> },
 
     #[error(
         "error spawning actor mesh: statuses: {}",
-        RankedValues::invert(&*.statuses)
+        RankedValues::invert(statuses)
     )]
     ActorSpawnError { statuses: RankedValues<Status> },