Skip to content

Commit a0aceab

Browse files
moonlimeta-codesync[bot]
authored andcommitted
remove spammy log when log forwarder is disabled (#1689)
Summary: Pull Request resolved: #1689 We could see a lot of such logs in agent tune job, they are not very meaningful, instead it adds noise to the debugging. Simply remove them. ``` D1028 13:41:14.902225 2072 fbcode/monarch/hyperactor_mesh/src/logging.rs:405] log sender unix:DXQZoTDccbIdARnDeVUKh0hf is not active, skip sending log ``` Reviewed By: pzhan9 Differential Revision: D85712862 fbshipit-source-id: f803995b07aed6a1fb0785b85fad4fd3ff66b17c
1 parent ccbed10 commit a0aceab

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

hyperactor_mesh/src/logging.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -397,11 +397,6 @@ impl LogSender for LocalLogSender {
397397
output_target: target,
398398
payload: Serialized::serialize(&payload)?,
399399
});
400-
} else {
401-
tracing::debug!(
402-
"log sender {} is not active, skip sending log",
403-
self.tx.addr()
404-
)
405400
}
406401

407402
Ok(())
@@ -412,11 +407,6 @@ impl LogSender for LocalLogSender {
412407
if TxStatus::Active == *self.status.borrow() {
413408
// Do not use tx.send, it will block the allocator as the child process state is unknown.
414409
self.tx.post(LogMessage::Flush { sync_version: None });
415-
} else {
416-
tracing::debug!(
417-
"log sender {} is not active, skip sending flush message",
418-
self.tx.addr()
419-
);
420410
}
421411
Ok(())
422412
}

0 commit comments

Comments
 (0)