Commit ab08436
build monarch_extension as extension-module (2) (#1611)
Summary:
Pull Request resolved: #1611
this is a patch of D84956118 where initialization of `rust_binding_args = ["--"] ` is changed to `rust_binding_args=[]`.
`setup-tools-rust` inserts its own `--` to pass flags to `rustc` (along with `-Zthreads=...`).
our extra `--` yields `-- -- -Zthreads=16 ...` so `-Zthreads=16` is misparsed as a positional input:
```
... --crate-type cdylib -- -Zthreads=16 ...
^^^^ ^^
(1st) (2nd)
```
Differential Revision: D849869211 parent f422354 commit ab08436
1 file changed
+4
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
120 | 121 | | |
121 | 122 | | |
122 | 123 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
| 124 | + | |
| 125 | + | |
128 | 126 | | |
129 | 127 | | |
130 | 128 | | |
| |||
138 | 136 | | |
139 | 137 | | |
140 | 138 | | |
141 | | - | |
| 139 | + | |
142 | 140 | | |
143 | 141 | | |
144 | 142 | | |
| |||
0 commit comments