Create torchx.specs.overlays module #1171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88545380. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
+ Coverage 91.66% 91.68% +0.02%
==========================================
Files 85 86 +1
Lines 6619 6636 +17
==========================================
+ Hits 6067 6084 +17
Misses 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2025
Summary: Create `torchx.specs.overlays` module to standardize how scheduler request overlays work. Currently overlays are JSON (`dict[str, object]`) that follows the same structure as the scheduler's request type. Overlays are stored as metadata in two places: 1. `AppDef.metadata`: job level overlays 2. `Role.metadata`: gang-level overlays Overlays follow the rules below: 1. value types must be the same as the scheduler's request type at the same attribute. 2. dicts get upserted 3. nested dicts get recursively overlayed 4. lists get appended, no deduplication attempts are made 5. lists are NOT recursed, that is, lists for which elements are containers are not recursively overlayed, they are simply treated as primitives. 6. primitive attributes are replaced Differential Revision: D88545380
facebook-github-bot
force-pushed
the
export-D88545380
branch
2 times, most recently
from
2bf966f to
d5cf746
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 6, 2025
Summary: Create `torchx.specs.overlays` module to standardize how scheduler request overlays work. Currently overlays are JSON (`dict[str, object]`) that follows the same structure as the scheduler's request type. Overlays are stored as metadata in two places: 1. `AppDef.metadata`: job level overlays 2. `Role.metadata`: gang-level overlays Overlays follow the rules below: 1. value types must be the same as the scheduler's request type at the same attribute. 2. dicts get upserted 3. nested dicts get recursively overlayed 4. lists get appended, no deduplication attempts are made 5. lists are NOT recursed, that is, lists for which elements are containers are not recursively overlayed, they are simply treated as primitives. 6. primitive attributes are replaced Differential Revision: D88545380
facebook-github-bot
force-pushed
the
export-D88545380
branch
from
d5cf746 to
0b5ce19
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 7, 2025
Summary: Create `torchx.specs.overlays` module to standardize how scheduler request overlays work. Currently overlays are JSON (`dict[str, object]`) that follows the same structure as the scheduler's request type. Overlays are stored as metadata in two places: 1. `AppDef.metadata`: job level overlays 2. `Role.metadata`: gang-level overlays Overlays follow the rules below: 1. value types must be the same as the scheduler's request type at the same attribute. 2. dicts get upserted 3. nested dicts get recursively overlayed 4. lists get appended, no deduplication attempts are made 5. lists are NOT recursed, that is, lists for which elements are containers are not recursively overlayed, they are simply treated as primitives. 6. primitive attributes are replaced Differential Revision: D88545380
facebook-github-bot
force-pushed
the
export-D88545380
branch
from
0b5ce19 to
cd34297
Compare
Summary: Create `torchx.specs.overlays` module to standardize how scheduler request overlays work. Currently overlays are JSON (`dict[str, object]`) that follows the same structure as the scheduler's request type. Overlays are stored as metadata in two places: 1. `AppDef.metadata`: job level overlays 2. `Role.metadata`: gang-level overlays Overlays follow the rules below: 1. value types must be the same as the scheduler's request type at the same attribute. 2. dicts get upserted 3. nested dicts get recursively overlayed 4. lists get appended, no deduplication attempts are made 5. lists are NOT recursed, that is, lists for which elements are containers are not recursively overlayed, they are simply treated as primitives. 6. primitive attributes are replaced Differential Revision: D88545380
facebook-github-bot
force-pushed
the
export-D88545380
branch
from
cd34297 to
5b871b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create
torchx.specs.overlaysmodule to standardize how scheduler request overlays work.Currently overlays are JSON (
dict[str, object]) that follows the same structure as the scheduler's request type.Overlays are stored as metadata in two places:
AppDef.metadata: job level overlaysRole.metadata: gang-level overlaysOverlays follow the rules below:
Differential Revision: D88545380