Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile metrics #460

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Profile metrics #460

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee7701
logging process timings
akvlad Feb 8, 2024
75ed5c1
logging process timings
akvlad Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions pyroscope/pyroscope.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const compiler = require('../parser/bnf')
const { readULeb32 } = require('./pprof')
const pprofBin = require('./pprof-bin/pkg/pprof_bin')
const { QrynBadRequest } = require('../lib/handlers/errors')
const { clusterName} = require('../common')
const { clusterName } = require('../common')

const HISTORY_TIMESPAN = 1000 * 60 * 60 * 24 * 7

Expand Down Expand Up @@ -201,24 +201,30 @@ const selectMergeStacktraces = async (req, res) => {
if (process.env.ADVANCED_PROFILES_MERGE_LIMIT) {
sqlReq.orderBy(['timestamp_ns', 'desc']).limit(parseInt(process.env.ADVANCED_PROFILES_MERGE_LIMIT))
}
let start = Date.now()
const profiles = await clickhouse.rawRequest(sqlReq.toString() + ' FORMAT RowBinary',
null,
DATABASE_NAME(),
{
responseType: 'arraybuffer'
})
const binData = Uint8Array.from(profiles.data)
req.log.debug(`profiles: ${binData.length / 1025} kB`)
req.log.debug(`selectMergeStacktraces: profiles downloaded: ${binData.length / 1025}kB in ${Date.now() - start}ms`)
start = Date.now()
require('./pprof-bin/pkg/pprof_bin').init_panic_hook()
const promises = []
const _ctxIdx = ++ctxIdx
let mergeTreeLat = BigInt(0)
let exportTreeLat = BigInt(0)
for (let i = 0; i < binData.length;) {
const [size, shift] = readULeb32(binData, i)
const uarray = Uint8Array.from(profiles.data.slice(i + shift, i + size + shift))
i += size + shift
promises.push(new Promise((resolve, reject) => setTimeout(() => {
try {
const start = process.hrtime?.bigint ? process.hrtime.bigint() : 0
pprofBin.merge_tree(_ctxIdx, uarray, `${typeRegex.sampleType}:${typeRegex.sampleUnit}`)
mergeTreeLat += (process.hrtime?.bigint ? process.hrtime.bigint() : 0) - start
resolve()
} catch (e) {
reject(e)
Expand All @@ -228,8 +234,13 @@ const selectMergeStacktraces = async (req, res) => {
let sResp = null
try {
await Promise.all(promises)
const start = process.hrtime?.bigint ? process.hrtime.bigint() : 0
sResp = pprofBin.export_tree(_ctxIdx, `${typeRegex.sampleType}:${typeRegex.sampleUnit}`)
exportTreeLat += (process.hrtime?.bigint ? process.hrtime.bigint() : 0) - start
} finally {
req.log.debug(`selectMergeStacktraces: profiles processed: ${promises.length} in ${Date.now() - start}ms`)
req.log.debug(`selectMergeStacktraces: mergeTree: ${mergeTreeLat / BigInt(1000000)}ms`)
req.log.debug(`selectMergeStacktraces: export_tree: ${exportTreeLat / BigInt(1000000)}ms`)
try { pprofBin.drop_tree(_ctxIdx) } catch (e) { req.log.error(e) }
}
return res.code(200).send(Buffer.from(sResp))
Expand Down