Skip to content

Commit 7412177

Browse files
committed
Fixed a bug where bombs were spawned as blue non-direction notes
1 parent cc9cbf7 commit 7412177

File tree

6 files changed

+17
-5
lines changed

6 files changed

+17
-5
lines changed

Assets/_Prefabs/Main_Menu.prefab

+1-1
Original file line numberDiff line numberDiff line change
@@ -16006,7 +16006,7 @@ MonoBehaviour:
1600616006
m_HorizontalOverflow: 0
1600716007
m_VerticalOverflow: 0
1600816008
m_LineSpacing: 1
16009-
m_Text: v0.1.3-dev by dev.play.repeat
16009+
m_Text: v0.1.3.1-dev by dev.play.repeat
1601016010
--- !u!1 &1359979013465415846
1601116011
GameObject:
1601216012
m_ObjectHideFlags: 0

Assets/_Scripts/CubeHandling.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class CubeHandling : MonoBehaviour
2222
public Vector3 _midPos;
2323
public Vector3 _endPos;
2424

25-
void Update()
25+
void FixedUpdate()
2626
{
2727
_songTime = _refNotesSpawner.audioSource.time + Time.smoothDeltaTime;
2828
float songTimeDistance = _songTime - (((float)_note.Time * _refNotesSpawner._BeatPerSec - _refNotesSpawner._spawnOffset));

Assets/_Scripts/NotesSpawner.cs

+9-1
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,17 @@ void Start()
8787
var notes = json.GetArray("_notes");
8888
foreach (var note in notes)
8989
{
90+
var type = note.Obj.GetNumber("_type");
91+
92+
// ignore bombs, will lead to a bug in GenerateNote which spawns a blue note
93+
if (type > 1)
94+
{
95+
continue;
96+
}
97+
9098
var n = new Note
9199
{
92-
Hand = (NoteType)note.Obj.GetNumber("_type"),
100+
Hand = (NoteType)type,
93101
CutDirection = (CutDirection)note.Obj.GetNumber("_cutDirection"),
94102
LineIndex = (int)note.Obj.GetNumber("_lineIndex"),
95103
LineLayer = (int)note.Obj.GetNumber("_lineLayer"),

Assets/_Scripts/ObstacleHandling.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class ObstacleHandling : MonoBehaviour
1515
public float _songTime;
1616
public float _height;
1717

18-
void Update()
18+
void FixedUpdate()
1919
{
2020
if (_refNotesSpawner != null && _refNotesSpawner.audioSource != null)
2121
{

Changelog.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Released
22

3+
# 0.1.3.1
4+
5+
* Fixed bug: Bombs were spawned as blue non-direction notes
6+
37
# 0.1.3
48

59
* New Feature: One saber songs are now supported (thanks to dhcdht)

ProjectSettings/ProjectSettings.asset

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ PlayerSettings:
118118
16:10: 1
119119
16:9: 1
120120
Others: 1
121-
bundleVersion: 0.1.3-dev
121+
bundleVersion: 0.1.3.1-dev
122122
preloadedAssets: []
123123
metroInputSource: 0
124124
wsaTransparentSwapchain: 0

0 commit comments

Comments
 (0)