Skip to content

Commit 72df4c0

Browse files
committed
Update kotlinx-coroutines to 1.6.0
Closes #69
1 parent b3f1edc commit 72df4c0

File tree

10 files changed

+181
-270
lines changed

10 files changed

+181
-270
lines changed

buildSrc/src/main/kotlin/Versions.kt

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ object Versions {
22
const val dokka = "1.6.10"
33
const val kotlin = "1.6.10"
44
const val kotlinBenchmark = "0.4.1"
5-
const val kotlinCoroutines = "1.5.2"
6-
const val kotlinCoroutinesTest = "1.5.2"
5+
const val kotlinCoroutines = "1.6.0"
76
const val ktor = "2.0.0-beta-1"
87
const val logback = "1.2.3"
98
const val versionsPlugin = "0.41.0"

kotlin-result-coroutines/build.gradle.kts

+1-25
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ kotlin {
2424
dependencies {
2525
implementation(kotlin("test-common"))
2626
implementation(kotlin("test-annotations-common"))
27+
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:${Versions.kotlinCoroutines}")
2728
}
2829
}
2930

3031
val jvmTest by getting {
3132
dependencies {
3233
implementation(kotlin("test-junit"))
3334
implementation(kotlin("test"))
34-
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:${Versions.kotlinCoroutinesTest}")
3535
}
3636
}
3737

@@ -40,30 +40,6 @@ kotlin {
4040
implementation(kotlin("test-js"))
4141
}
4242
}
43-
44-
val nativeTest by creating {
45-
dependsOn(commonTest)
46-
}
47-
48-
val linuxX64Test by getting {
49-
dependsOn(nativeTest)
50-
}
51-
52-
val mingwX64Test by getting {
53-
dependsOn(nativeTest)
54-
}
55-
56-
val macosX64Test by getting {
57-
dependsOn(nativeTest)
58-
}
59-
60-
val iosX64Test by getting {
61-
dependsOn(nativeTest)
62-
}
63-
64-
val iosArm64Test by getting {
65-
dependsOn(nativeTest)
66-
}
6743
}
6844
}
6945

kotlin-result-coroutines/src/commonTest/kotlin/com.github.michaelbull.result.coroutines/RunBlockingTest.kt

-14
This file was deleted.

kotlin-result-coroutines/src/commonTest/kotlin/com.github.michaelbull.result.coroutines/binding/SuspendableBindingTest.kt

+61-72
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,21 @@ package com.github.michaelbull.result.coroutines.binding
33
import com.github.michaelbull.result.Err
44
import com.github.michaelbull.result.Ok
55
import com.github.michaelbull.result.Result
6-
import com.github.michaelbull.result.coroutines.runBlockingTest
6+
import kotlinx.coroutines.ExperimentalCoroutinesApi
77
import kotlinx.coroutines.delay
8+
import kotlinx.coroutines.test.runTest
89
import kotlin.test.Test
910
import kotlin.test.assertEquals
1011
import kotlin.test.assertFalse
1112
import kotlin.test.assertTrue
1213

14+
@ExperimentalCoroutinesApi
1315
class SuspendableBindingTest {
1416

1517
private object BindingError
1618

1719
@Test
18-
fun returnsOkIfAllBindsSuccessful() {
20+
fun returnsOkIfAllBindsSuccessful() = runTest {
1921
suspend fun provideX(): Result<Int, BindingError> {
2022
delay(1)
2123
return Ok(1)
@@ -26,23 +28,20 @@ class SuspendableBindingTest {
2628
return Ok(2)
2729
}
2830

29-
return runBlockingTest {
30-
val result = binding<Int, BindingError> {
31-
val x = provideX().bind()
32-
val y = provideY().bind()
33-
x + y
34-
}
35-
36-
assertTrue(result is Ok)
37-
assertEquals(
38-
expected = 3,
39-
actual = result.value
40-
)
31+
val result = binding<Int, BindingError> {
32+
val x = provideX().bind()
33+
val y = provideY().bind()
34+
x + y
4135
}
36+
37+
assertEquals(
38+
expected = Ok(3),
39+
actual = result
40+
)
4241
}
4342

4443
@Test
45-
fun returnsOkIfAllBindsOfDifferentTypeAreSuccessful() {
44+
fun returnsOkIfAllBindsOfDifferentTypeAreSuccessful() = runTest {
4645
suspend fun provideX(): Result<String, BindingError> {
4746
delay(1)
4847
return Ok("1")
@@ -53,23 +52,20 @@ class SuspendableBindingTest {
5352
return Ok(x + 2)
5453
}
5554

56-
return runBlockingTest {
57-
val result = binding<Int, BindingError> {
58-
val x = provideX().bind()
59-
val y = provideY(x.toInt()).bind()
60-
y
61-
}
62-
63-
assertTrue(result is Ok)
64-
assertEquals(
65-
expected = 3,
66-
actual = result.value
67-
)
55+
val result = binding<Int, BindingError> {
56+
val x = provideX().bind()
57+
val y = provideY(x.toInt()).bind()
58+
y
6859
}
60+
61+
assertEquals(
62+
expected = Ok(3),
63+
actual = result
64+
)
6965
}
7066

7167
@Test
72-
fun returnsFirstErrIfBindingFailed() {
68+
fun returnsFirstErrIfBindingFailed() = runTest {
7369
suspend fun provideX(): Result<Int, BindingError> {
7470
delay(1)
7571
return Ok(1)
@@ -85,27 +81,25 @@ class SuspendableBindingTest {
8581
return Ok(2)
8682
}
8783

88-
return runBlockingTest {
89-
val result = binding<Int, BindingError> {
90-
val x = provideX().bind()
91-
val y = provideY().bind()
92-
val z = provideZ().bind()
93-
x + y + z
94-
}
95-
96-
assertTrue(result is Err)
97-
assertEquals(
98-
expected = BindingError,
99-
actual = result.error
100-
)
84+
val result = binding<Int, BindingError> {
85+
val x = provideX().bind()
86+
val y = provideY().bind()
87+
val z = provideZ().bind()
88+
x + y + z
10189
}
90+
91+
assertEquals(
92+
expected = Err(BindingError),
93+
actual = result
94+
)
10295
}
10396

10497
@Test
105-
fun returnsStateChangedUntilFirstBindFailed() {
98+
fun returnsStateChangedUntilFirstBindFailed() = runTest {
10699
var xStateChange = false
107100
var yStateChange = false
108101
var zStateChange = false
102+
109103
suspend fun provideX(): Result<Int, BindingError> {
110104
delay(1)
111105
xStateChange = true
@@ -124,27 +118,25 @@ class SuspendableBindingTest {
124118
return Err(BindingError)
125119
}
126120

127-
runBlockingTest {
128-
val result = binding<Int, BindingError> {
129-
val x = provideX().bind()
130-
val y = provideY().bind()
131-
val z = provideZ().bind()
132-
x + y + z
133-
}
134-
135-
assertTrue(result is Err)
136-
assertEquals(
137-
expected = BindingError,
138-
actual = result.error
139-
)
140-
assertTrue(xStateChange)
141-
assertTrue(yStateChange)
142-
assertFalse(zStateChange)
121+
val result = binding<Int, BindingError> {
122+
val x = provideX().bind()
123+
val y = provideY().bind()
124+
val z = provideZ().bind()
125+
x + y + z
143126
}
127+
128+
assertEquals(
129+
expected = Err(BindingError),
130+
actual = result
131+
)
132+
133+
assertTrue(xStateChange)
134+
assertTrue(yStateChange)
135+
assertFalse(zStateChange)
144136
}
145137

146138
@Test
147-
fun returnsFirstErrIfBindingsOfDifferentTypesFailed() {
139+
fun returnsFirstErrIfBindingsOfDifferentTypesFailed() = runTest {
148140
suspend fun provideX(): Result<Int, BindingError> {
149141
delay(1)
150142
return Ok(1)
@@ -160,19 +152,16 @@ class SuspendableBindingTest {
160152
return Ok(2)
161153
}
162154

163-
return runBlockingTest {
164-
val result = binding<Int, BindingError> {
165-
val x = provideX().bind()
166-
val y = provideY().bind()
167-
val z = provideZ().bind()
168-
x + y.toInt() + z
169-
}
170-
171-
assertTrue(result is Err)
172-
assertEquals(
173-
expected = BindingError,
174-
actual = result.error
175-
)
155+
val result = binding<Int, BindingError> {
156+
val x = provideX().bind()
157+
val y = provideY().bind()
158+
val z = provideZ().bind()
159+
x + y.toInt() + z
176160
}
161+
162+
assertEquals(
163+
expected = Err(BindingError),
164+
actual = result
165+
)
177166
}
178167
}

kotlin-result-coroutines/src/jsTest/kotlin/com.github.michaelbull.result.coroutines/RunBlockingTest.kt

-13
This file was deleted.

0 commit comments

Comments
 (0)