From 60353d825cb39ac06f41f85705fb5d5eca5ecbf4 Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Sat, 19 Apr 2025 12:16:17 +0900 Subject: [PATCH] Remove redundant get() methods from "Config" classes Signed-off-by: Johnny Lim --- build.gradle | 6 +++++- .../main/java/io/micrometer/elastic/ElasticConfig.java | 8 -------- .../main/java/io/micrometer/ganglia/GangliaConfig.java | 8 -------- .../main/java/io/micrometer/graphite/GraphiteConfig.java | 9 --------- 4 files changed, 5 insertions(+), 26 deletions(-) diff --git a/build.gradle b/build.gradle index 5a70e41e0f..0c07df4949 100644 --- a/build.gradle +++ b/build.gradle @@ -399,7 +399,11 @@ subprojects { ignoreMissingClasses = true includeSynthetic = true - classExcludes = [] + classExcludes = [ + 'io.micrometer.elastic.ElasticConfig', + 'io.micrometer.ganglia.GangliaConfig', + 'io.micrometer.graphite.GraphiteConfig' + ] compatibilityChangeExcludes = [ "METHOD_NEW_DEFAULT" ] packageExcludes = ['io.micrometer.shaded.*', 'io.micrometer.statsd.internal'] diff --git a/implementations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java b/implementations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java index 17fefbfed4..421f60e7d8 100644 --- a/implementations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java +++ b/implementations/micrometer-registry-elastic/src/main/java/io/micrometer/elastic/ElasticConfig.java @@ -39,14 +39,6 @@ public interface ElasticConfig extends StepRegistryConfig { */ ElasticConfig DEFAULT = k -> null; - /** - * Get the value associated with a key. - * @param key Key to look up in the config. - * @return Value for the key or null if no key is present. - */ - @Nullable - String get(String key); - /** * Property prefix to prepend to configuration names. * @return property prefix diff --git a/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java b/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java index e4f51b27ec..d25ff0b66d 100644 --- a/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java +++ b/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaConfig.java @@ -37,14 +37,6 @@ public interface GangliaConfig extends StepRegistryConfig { */ GangliaConfig DEFAULT = k -> null; - /** - * Get the value associated with a key. - * @param key Key to lookup in the config. - * @return Value for the key or null if no key is present. - */ - @Nullable - String get(String key); - /** * @return Property prefix to prepend to configuration names. */ diff --git a/implementations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java b/implementations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java index 6c9eed768e..008636bddb 100644 --- a/implementations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java +++ b/implementations/micrometer-registry-graphite/src/main/java/io/micrometer/graphite/GraphiteConfig.java @@ -15,7 +15,6 @@ */ package io.micrometer.graphite; -import io.micrometer.common.lang.Nullable; import io.micrometer.core.instrument.config.validate.Validated; import io.micrometer.core.instrument.dropwizard.DropwizardConfig; @@ -36,14 +35,6 @@ public interface GraphiteConfig extends DropwizardConfig { */ GraphiteConfig DEFAULT = k -> null; - /** - * Get the value associated with a key. - * @param key Key to lookup in the config. - * @return Value for the key or null if no key is present. - */ - @Nullable - String get(String key); - /** * @return Property prefix to prepend to configuration names. */