Skip to content

Commit cf1ba90

Browse files
author
Mateo00
committed
Correction following code review
Signed-off-by: Mateo00 <[email protected]>
1 parent 1c0518b commit cf1ba90

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

proxy-server/src/main/java/io/micrometer/prometheus/rsocket/PrometheusController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ String receiveScrapePayload(Payload payload, Timer.Sample timing) {
213213
ByteBufUtil.getBytes(sliceData, sliceData.readerIndex(), sliceData.readableBytes(), false));
214214

215215
String uncompressed = Snappy.uncompressString(decrypted);
216-
if (!this.properties.getConnectedMetricsMetadata()) {
216+
if (!this.properties.getPublishConnectedMetricsMetadata()) {
217217
uncompressed = uncompressed.replaceAll("(?m)^#.*\n", "");
218218
}
219219
scrapePayload.record(uncompressed.length());

proxy-server/src/main/java/io/micrometer/prometheus/rsocket/PrometheusControllerProperties.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class PrometheusControllerProperties {
3737
* Whether to enable publishing of Prometheus metadata (lines "# HELP ..." and lines "# TYPE ...") in the payload returned by the /metrics/connected endpoint.
3838
* Disabling metadata publishing reduces the amount of data sent sent on each scrape.
3939
*/
40-
private boolean connectedMetricsMetadata = true;
40+
private boolean publishConnectedMetricsMetadata = true;
4141

4242
public int getTcpPort() {
4343
return tcpPort;
@@ -55,11 +55,11 @@ public void setWebsocketPort(int websocketPort) {
5555
this.websocketPort = websocketPort;
5656
}
5757

58-
public boolean getConnectedMetricsMetadata() {
59-
return connectedMetricsMetadata;
58+
public boolean getPublishConnectedMetricsMetadata() {
59+
return publishConnectedMetricsMetadata;
6060
}
6161

62-
public void setConnectedMetricsMetadata(boolean connectedMetricsMetadata) {
63-
this.connectedMetricsMetadata = connectedMetricsMetadata;
62+
public void setPublishConnectedMetricsMetadata(boolean publishConnectedMetricsMetadata) {
63+
this.publishConnectedMetricsMetadata = publishConnectedMetricsMetadata;
6464
}
6565
}

0 commit comments

Comments
 (0)