Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI_CACHE_ACR_NAME Secret for CI/CD Not Documented #4424

Open
macromania opened this issue Mar 18, 2025 · 1 comment · May be fixed by #4453
Open

CI_CACHE_ACR_NAME Secret for CI/CD Not Documented #4424

macromania opened this issue Mar 18, 2025 · 1 comment · May be fixed by #4453
Assignees

Comments

@macromania
Copy link

Currently CI_CACHE_ACR_NAME secret is used throughout the workflows and lack of it in the secrets fails the workflows in a repo created from scratch. This required secret is visible in the Makefile and action yamls but not at the documentation.

Most probably this page is the best place to require it:
https://microsoft.github.io/AzureTRE/latest/tre-admins/setup-instructions/cicd-pre-deployment-steps/

@macromania macromania changed the title CI_CACHE_ACR_NAME Not Documented CI_CACHE_ACR_NAME Secret for CI/CD Not Documented Mar 18, 2025
@tamirkamara
Copy link
Collaborator

tamirkamara commented Mar 23, 2025

I agree there's some documentation needed but not for the secret itself.
To explain, I would say this "secret" is injected from parent workflows and not needed to be present in GitHub environment secrets. The errors you are referring to are probably due to the main branch not being run prior to any other PR workflow. The ACR in CI_CACHE_ACR_NAME is being created by that run and later used in the PRs.

@LizaShak LizaShak self-assigned this Mar 30, 2025
LizaShak added a commit that referenced this issue Mar 30, 2025
Fixes #4424

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/4424?shareId=XXXX-XXXX-XXXX-XXXX).
@LizaShak LizaShak linked a pull request Mar 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants