Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert non-secrets to GitHub environment variables to improve troubleshooting #4427

Open
ericmeans3cloud opened this issue Mar 19, 2025 · 1 comment
Labels
enhancement New feature or request story Stories are the smallest unit of work to be done for a project.

Comments

@ericmeans3cloud
Copy link

A number of the values passed to the GitHub workflows as secrets are not actually secrets and should be converted to variables. e.g. TRE_ID is not a secret value and could be a variable.

Converting these to variables would make it easier to verify that all values are present and correct if the deployment fails - this is mostly necessary when deploying a new TRE (especially when using manual auth as it's easy to forget to add a client ID or put the wrong one in).

The only ones that look like they actually should be secrets are:

API_CLIENT_SECRET
APPLICATION_ADMIN_CLIENT_SECRET
TEST_WORKSPACE_APP_SECRET
TEST_ACCOUNT_CLIENT_SECRET
AZURE_CREDENTIALS

@ericmeans3cloud
Copy link
Author

Probably should have created this in the main repo, please transfer. :)

@marrobi marrobi transferred this issue from microsoft/AzureTRE-Deployment Mar 19, 2025
@marrobi marrobi added enhancement New feature or request story Stories are the smallest unit of work to be done for a project. labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Development

No branches or pull requests

2 participants