Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize passing params to bundles #4437

Merged
merged 7 commits into from
Mar 24, 2025
Merged

Conversation

tamirkamara
Copy link
Collaborator

@tamirkamara tamirkamara commented Mar 23, 2025

Resolves #4436

What is being addressed

When bundles require parameters that exist in the config.json file, we pass them by hard-coding them into the python code of the resource processor. There's a simpler way by using the rp_bundle_values method but it wasn't setup in a way that is accessible.

How is this addressed

  • Update resource processor's TF code with a way to simply pass values from the config.yaml file.
  • Remove environment variables from the resource processor's code that are only meant for the bundles and not required by the RP process.

Copy link

github-actions bot commented Mar 23, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 66b11c8.

♻️ This comment has been updated with latest results.

@tamirkamara tamirkamara marked this pull request as ready for review March 23, 2025 12:35
@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019013860 (with refid 587d7402)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara requested a review from yuvalyaron March 23, 2025 13:51
@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid 587d7402)

(in response to this comment from @tamirkamara)

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid 587d7402)

(in response to this comment from @tamirkamara)

1 similar comment
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid 587d7402)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test-destroy-env

Copy link

Destroying PR test environment (RG: rg-tre587d7402)... (run: https://github.com/microsoft/AzureTRE/actions/runs/14021068525)

Copy link

Destroying branch test environment (RG: rg-trefb0be1b7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/14021068525)

Copy link

Branch test environment destroy complete (RG: rg-trefb0be1b7)

Copy link

PR test environment destroy complete (RG: rg-tre587d7402)

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14021299389 (with refid 587d7402)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) March 23, 2025 18:45
Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can the static web work be in a separate PR?

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14034838873 (with refid 587d7402)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14037683806 (with refid 587d7402)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@tamirkamara tamirkamara merged commit ac02819 into main Mar 24, 2025
71 checks passed
@tamirkamara tamirkamara deleted the tamirkamara/4436-bundle-params branch March 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organize settings for bundles
3 participants