-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize passing params to bundles #4437
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 66b11c8. ♻️ This comment has been updated with latest results. |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019013860 (with refid (in response to this comment from @tamirkamara) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid (in response to this comment from @tamirkamara) |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid (in response to this comment from @tamirkamara) |
1 similar comment
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14019677137 (with refid (in response to this comment from @tamirkamara) |
/test-destroy-env |
Destroying PR test environment (RG: rg-tre587d7402)... (run: https://github.com/microsoft/AzureTRE/actions/runs/14021068525) |
Destroying branch test environment (RG: rg-trefb0be1b7)... (run: https://github.com/microsoft/AzureTRE/actions/runs/14021068525) |
Branch test environment destroy complete (RG: rg-trefb0be1b7) |
PR test environment destroy complete (RG: rg-tre587d7402) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14021299389 (with refid (in response to this comment from @tamirkamara) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can the static web work be in a separate PR?
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14034838873 (with refid (in response to this comment from @tamirkamara) |
/test |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/14037683806 (with refid (in response to this comment from @tamirkamara) |
/test |
Resolves #4436
What is being addressed
When bundles require parameters that exist in the config.json file, we pass them by hard-coding them into the python code of the resource processor. There's a simpler way by using the rp_bundle_values method but it wasn't setup in a way that is accessible.
How is this addressed