Merge pull request #2465 from kilifu/fix/missing-using

baywet · web-flow · commit 9318c00c3146 · 2025-08-15T21:21:29.000-04:00
fix: add missing disposable for stream
diff --git a/src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs b/src/Microsoft.OpenApi/Reader/OpenApiModelFactory.cs
@@ -76,7 +76,10 @@ public static async Task<ReadResult> LoadAsync(string url, OpenApiReaderSettings
         {
             settings ??= DefaultReaderSettings.Value;
             var (stream, format) = await RetrieveStreamAndFormatAsync(url, settings, token).ConfigureAwait(false);
-            return await LoadAsync(stream, format, settings, token).ConfigureAwait(false);
+            using (stream)
+            {
+                return await LoadAsync(stream, format, settings, token).ConfigureAwait(false);
+            }
         }
 
         /// <summary>
@@ -94,7 +97,10 @@ public static async Task<ReadResult> LoadAsync(string url, OpenApiReaderSettings
         {
             settings ??= DefaultReaderSettings.Value;
             var (stream, format) = await RetrieveStreamAndFormatAsync(url, settings, token).ConfigureAwait(false);
-            return await LoadAsync<T>(stream, version, openApiDocument, format, settings, token);
+            using (stream)
+            {
+                return await LoadAsync<T>(stream, version, openApiDocument, format, settings, token);
+            }
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,10 @@ public static async Task<ReadResult> LoadAsync(string url, OpenApiReaderSettings`
`76`	`76`	`{`
`77`	`77`	`settings ??= DefaultReaderSettings.Value;`
`78`	`78`	`var (stream, format) = await RetrieveStreamAndFormatAsync(url, settings, token).ConfigureAwait(false);`
`79`		`- return await LoadAsync(stream, format, settings, token).ConfigureAwait(false);`
	`79`	`+ using (stream)`
	`80`	`+ {`
	`81`	`+ return await LoadAsync(stream, format, settings, token).ConfigureAwait(false);`
	`82`	`+ }`
`80`	`83`	`}`
`81`	`84`
`82`	`85`	`/// <summary>`
`@@ -94,7 +97,10 @@ public static async Task<ReadResult> LoadAsync(string url, OpenApiReaderSettings`
`94`	`97`	`{`
`95`	`98`	`settings ??= DefaultReaderSettings.Value;`
`96`	`99`	`var (stream, format) = await RetrieveStreamAndFormatAsync(url, settings, token).ConfigureAwait(false);`
`97`		`- return await LoadAsync<T>(stream, version, openApiDocument, format, settings, token);`
	`100`	`+ using (stream)`
	`101`	`+ {`
	`102`	`+ return await LoadAsync<T>(stream, version, openApiDocument, format, settings, token);`
	`103`	`+ }`
`98`	`104`	`}`
`99`	`105`
`100`	`106`	`/// <summary>`