address feedback

Author: javiercn

dotnet/samples/AGUIClientServer/AGUIClient/AGUIClientSerializerContext.cs

@@ -9,6 +9,4 @@ namespace AGUIClient;
 
 [JsonSerializable(typeof(SensorRequest))]
 [JsonSerializable(typeof(SensorResponse))]
-internal sealed partial class AGUIClientSerializerContext : JsonSerializerContext
-{
-}
+internal sealed partial class AGUIClientSerializerContext : JsonSerializerContext;

dotnet/samples/AGUIClientServer/AGUIServer/AGUIServerSerializerContext.cs

@@ -6,6 +6,4 @@ namespace AGUIServer;
 
 [JsonSerializable(typeof(ServerWeatherForecastRequest))]
 [JsonSerializable(typeof(ServerWeatherForecastResponse))]
-internal sealed partial class AGUIServerSerializerContext : JsonSerializerContext
-{
-}
+internal sealed partial class AGUIServerSerializerContext : JsonSerializerContext;

dotnet/samples/AGUIClientServer/AGUIServer/ServerWeatherForecastRequest.cs

@@ -5,6 +5,5 @@ namespace AGUIServer;
 internal sealed class ServerWeatherForecastRequest
 {
     public DateTime Date { get; set; }
-
     public string Location { get; set; } = "Seattle";
 }

dotnet/src/Microsoft.Agents.AI.AGUI/AGUIChatClient.cs

@@ -50,14 +50,8 @@ private static JsonSerializerOptions CombineJsonSerializerOptions(JsonSerializer
             return AGUIJsonSerializerContext.Default.Options;
         }
 
-        // Create a new JsonSerializerOptions based on the provided one
         var combinedOptions = new JsonSerializerOptions(jsonSerializerOptions);
-
-        // Add the AGUI context to the type info resolver chain if not already present
-        if (!combinedOptions.TypeInfoResolverChain.Any(r => r == AGUIJsonSerializerContext.Default))
-        {
-            combinedOptions.TypeInfoResolverChain.Insert(0, AGUIJsonSerializerContext.Default);
-        }
+        combinedOptions.TypeInfoResolverChain.Add(AGUIJsonSerializerContext.Default);
 
         return combinedOptions;
     }
@@ -107,7 +101,7 @@ public async override IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseA
             if (conversationId == null && firstUpdate == null)
             {
                 firstUpdate = update;
-                if (firstUpdate.AdditionalProperties != null && firstUpdate.AdditionalProperties.TryGetValue("agui_thread_id", out var threadIdObj) && threadIdObj is string threadId)
+                if (firstUpdate.AdditionalProperties?.TryGetValue("agui_thread_id", out string? threadId) is true)
                 {
                     // Capture the thread id from the first update to use as conversation id if none was provided
                     conversationId = threadId;
@@ -170,7 +164,7 @@ public AGUIChatClientHandler(
             Uri metadataUri = string.IsNullOrEmpty(endpoint) && httpClient.BaseAddress is not null
                 ? httpClient.BaseAddress
                 : new Uri(endpoint, UriKind.RelativeOrAbsolute);
-            this.Metadata = new ChatClientMetadata("AGUI", metadataUri, null);
+            this.Metadata = new ChatClientMetadata("ag-ui", metadataUri, null);
         }
 
         public ChatClientMetadata Metadata { get; }
@@ -194,10 +188,10 @@ public async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseAsync(
                 throw new ArgumentNullException(nameof(messages));
             }
 
-            var runId = $"run_{Guid.NewGuid()}";
+            var runId = $"run_{Guid.NewGuid():N}";
             var messagesList = messages.ToList(); // Avoid triggering the enumerator multiple times.
             var threadId = ExtractTemporaryThreadId(messagesList) ??
-                ExtractThreadIdFromOptions(options) ?? $"thread_{Guid.NewGuid()}";
+                ExtractThreadIdFromOptions(options) ?? $"thread_{Guid.NewGuid():N}";
 
             // Create the input for the AGUI service
             var input = new RunAgentInput
@@ -291,9 +285,7 @@ threadIdObj is not string threadId ||
                 return null;
             }
 
-            if (content.AdditionalProperties == null ||
-              !content.AdditionalProperties.TryGetValue("agui_thread_id", out var threadIdObj) ||
-              threadIdObj is not string threadId ||
+            if (content.AdditionalProperties?.TryGetValue("agui_thread_id", out string? threadId) is not true ||
               string.IsNullOrEmpty(threadId))
             {
                 return null;

dotnet/src/Microsoft.Agents.AI.AGUI/Shared/AGUIChatMessageExtensions.cs

@@ -115,7 +115,7 @@ public static IEnumerable<AGUIMessage> AsAGUIMessages(
     {
         foreach (var message in chatMessages)
         {
-            message.MessageId ??= Guid.NewGuid().ToString();
+            message.MessageId ??= Guid.NewGuid().ToString("N");
             if (message.Role == ChatRole.Tool)
             {
                 foreach (var toolMessage in MapToolMessages(jsonSerializerOptions, message))