Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image generation endpoint #13

Open
5 tasks
stuartleeks opened this issue Aug 22, 2024 · 4 comments
Open
5 tasks

Add support for image generation endpoint #13

stuartleeks opened this issue Aug 22, 2024 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@stuartleeks
Copy link
Collaborator

stuartleeks commented Aug 22, 2024

See https://learn.microsoft.com/en-us/azure/ai-services/openai/reference#image-generation

  • add generator for image generation and include in default generators
  • validate image generation endpoint with record/replay
  • determine how rate-limiting is applied and add to the simulator rate-limiting
  • add tests
  • add load test

(from stuartleeks/aoai-simulated-api#48)

@stuartleeks stuartleeks added help wanted Extra attention is needed details-needed and removed details-needed labels Aug 22, 2024
@martinpeck martinpeck self-assigned this Sep 11, 2024
@martinpeck
Copy link
Member

Questions:

  1. how many variations of images do we need?
  2. I assume that we don't need to show a "relevant" image. Correct?
  3. There are two ways images can be returned: as a URL or as Base64. Does the URL need to resolve to anything?
  4. If the url needs to resolve, do we need to create all of the sizes, image types etc? I don't see any need (I can't imagine that this will impact perf testing or other load testing.

@stuartleeks
Copy link
Collaborator Author

  1. how many variations of images do we need?
    I guess we can start with one for the initial implementation and add more later?
  1. I assume that we don't need to show a "relevant" image. Correct?
    Correct - if we're faking the image then it doesn't need to be relevant.
  1. There are two ways images can be returned: as a URL or as Base64. Does the URL need to resolve to anything?
    I think it would be good for the URL to resolve to an endpoint in the API that will serve up the image content. That way any client calling the API and getting the URL can still follow the URL to get the content
  1. If the url needs to resolve, do we need to create all of the sizes, image types etc? I don't see any need (I can't imagine that this will impact perf testing or other load testing.
    As with image variation, I suggest we start simple and expand later

@stuartleeks
Copy link
Collaborator Author

For the record/replay mode, I imagine that the base64 image option should just work. For the url response the recorder will need to do some work to change the returned URL in the response so that it resolves via the simulator (and can then record the request to the image URL as well)

@martinpeck
Copy link
Member

I'm going to un-assign myself from this.

@martinpeck martinpeck removed their assignment Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants