Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for decentralized-rbac app is a bit incomplete #246

Closed
all-seeing-code opened this issue Jan 28, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@all-seeing-code
Copy link

Some related issues which I faced when trying to run the application locally in a dev container.

  1. del-cli is not pre-installed which means couldn't run npm run build out of the box in the dev container as mentioned in the docs.
  2. No Makefile. Unlike other applications, this one doesn't have a make file which makes it a little painful to run the application. I had to figure out the correct command: /opt/ccf_virtual/bin/sandbox.sh --js-app-bundle ./dist/ to start the application.
  3. The GET/POST requests valid for the application are missing from the README.md.

I don't expect or require a fix for this issue but keeping it here as an issue log.

@all-seeing-code all-seeing-code added the bug Something isn't working label Jan 28, 2024
@achamayou
Copy link
Member

@all-seeing-code it looks like del-cli is listed in dev dependencies though: https://github.com/microsoft/ccf-app-samples/blob/main/decentralize-rbac-app/package.json#L45, I am not extremely familiar with npm but it seems to me that you would expect to install devDependencies before being able to do a run build?

@eddyashton
Copy link
Member

Resolved by #248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants