fix: CA1308 (#335)

* CA1002

* CA1308

* pr build check

* _

* pr build check2

* CA1308

* fixed conversation suggestions

Co-authored-by: Daniel Akili <[email protected]>

Author: daniel-akili

.editorconfig

@@ -609,9 +609,6 @@ dotnet_diagnostic.CA1304.severity = suggestion
 # CA1822: Mark members as static
 dotnet_diagnostic.CA1822.severity = suggestion
 
-# CA1308: Normalize strings to uppercase
-dotnet_diagnostic.CA1308.severity = suggestion
-
 # CA1307: Specify StringComparison for clarity
 dotnet_diagnostic.CA1307.severity = suggestion
 

src/Microsoft.ComponentDetection.Contracts/TypedComponent/LinuxComponent.cs

@@ -55,27 +55,27 @@ public override PackageURL PackageUrl
 
         private bool IsUbuntu()
         {
-            return this.Distribution.ToLowerInvariant() == "ubuntu";
+            return this.Distribution.ToUpperInvariant() == "UBUNTU";
         }
 
         private bool IsDebian()
         {
-            return this.Distribution.ToLowerInvariant() == "debian";
+            return this.Distribution.ToUpperInvariant() == "DEBIAN";
         }
 
         private bool IsCentOS()
         {
-            return this.Distribution.ToLowerInvariant() == "centos";
+            return this.Distribution.ToUpperInvariant() == "CENTOS";
         }
 
         private bool IsFedora()
         {
-            return this.Distribution.ToLowerInvariant() == "fedora";
+            return this.Distribution.ToUpperInvariant() == "FEDORA";
         }
 
         private bool IsRHEL()
         {
-            return this.Distribution.ToLowerInvariant() == "red hat enterprise linux";
+            return this.Distribution.ToUpperInvariant() == "RED HAT ENTERPRISE LINUX";
         }
     }
 }

src/Microsoft.ComponentDetection.Contracts/TypedComponent/PipComponent.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics.CodeAnalysis;
 using PackageUrl;
 
 namespace Microsoft.ComponentDetection.Contracts.TypedComponent
@@ -21,6 +22,7 @@ public PipComponent(string name, string version)
 
         public override ComponentType Type => ComponentType.Pip;
 
+        [SuppressMessage("Usage", "CA1308:Normalize String to Uppercase", Justification = "Casing cannot be overwritten.")]
         public override string Id => $"{this.Name} {this.Version} - {this.Type}".ToLowerInvariant();
 
         public override PackageURL PackageUrl => new PackageURL("pypi", null, this.Name, this.Version, null, null);

src/Microsoft.ComponentDetection.Detectors/cocoapods/PodComponentDetector.cs

@@ -404,9 +404,9 @@ public string GetSpecRepositoryOfSpec(string specName)
                     {
                         // CocoaPods specs are stored in a git repo but depending on settings/CocoaPods version
                         // the repo is shown differently in the Podfile.lock
-                        return repository.Key.ToLowerInvariant() switch
+                        return repository.Key.ToUpperInvariant() switch
                         {
-                            "trunk" or "https://github.com/cocoapods/specs.git" => "trunk",
+                            "TRUNK" or "https://github.com/cocoapods/specs.git" => "TRUNK",
                             _ => repository.Key,
                         };
                     }

src/Microsoft.ComponentDetection.Detectors/go/GoComponentDetector.cs

@@ -75,17 +75,17 @@ protected override async Task OnFileFound(ProcessRequest processRequest, IDictio
                 }
                 else
                 {
-                    var fileExtension = Path.GetExtension(file.Location).ToLowerInvariant();
+                    var fileExtension = Path.GetExtension(file.Location).ToUpperInvariant();
                     switch (fileExtension)
                     {
-                        case ".mod":
+                        case ".MOD":
                         {
                             this.Logger.LogVerbose("Found Go.mod: " + file.Location);
                             this.ParseGoModFile(singleFileComponentRecorder, file);
                             break;
                         }
 
-                        case ".sum":
+                        case ".SUM":
                         {
                             this.Logger.LogVerbose("Found Go.sum: " + file.Location);
                             this.ParseGoSumFile(singleFileComponentRecorder, file);

src/Microsoft.ComponentDetection.Detectors/linux/LinuxContainerDetector.cs

@@ -40,9 +40,11 @@ public class LinuxContainerDetector : IComponentDetector
 
         public async Task<IndividualDetectorScanResult> ExecuteDetectorAsync(ScanRequest request)
         {
+#pragma warning disable CA1308
             var imagesToProcess = request.ImagesToScan?.Where(image => !string.IsNullOrWhiteSpace(image))
                 .Select(image => image.ToLowerInvariant())
                 .ToList();
+#pragma warning restore CA1308
 
             if (imagesToProcess == null || !imagesToProcess.Any())
             {

src/Microsoft.ComponentDetection.Detectors/pip/PythonVersion.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using System.Text.RegularExpressions;
 
@@ -149,6 +150,7 @@ public int CompareTo(PythonVersion other)
             return devNumberComparison;
         }
 
+        [SuppressMessage("Usage", "CA1308:Normalize String to Uppercase", Justification = "Casing cannot be overwritten.")]
         private static int ComparePreRelease(PythonVersion a, PythonVersion b)
         {
             if (string.IsNullOrEmpty(a.PreReleaseLabel) && string.IsNullOrEmpty(b.PreReleaseLabel))

src/Microsoft.ComponentDetection.Detectors/rust/Contracts/CargoPackage.cs

@@ -35,6 +35,7 @@ public override bool Equals(object obj)
                    string.Equals(this.Checksum, package.Checksum);
         }
 
+        [SuppressMessage("Usage", "CA1308:Normalize String to Uppercase", Justification = "Casing cannot be overwritten.")]
         public override int GetHashCode()
         {
             return HashCode.Combine(

test/Microsoft.ComponentDetection.Detectors.Tests/PipComponentDetectorTests.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;