-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using incremental models on Synapse REPLICATE table distribution #107
Comments
Hi. First, I want to say thanks to all the contributors here for making it possible to use dbt with Azure Synapse. I've been running through a series of tests, and bumped into this error. Here's a bit more detail on the problem for clarity. The test case was - Distribution of the model was changed to REPLICATE Model{{ config(materialized='incremental'
, index='clustered index(OLDACNUM)'
, dist='REPLICATE'
, on_schema_change='sync_all_columns' ) }}
SELECT TOP (1000)
[RecordCreateRunId]
,[DEBTORNUM]
,[OLDACNUM]
,[CREDCOLACTION]
,[LASTSTMTDATE]
,[CUST_TYPE]
,[LETTERDATE]
,[CHARGE_CODE]
,[NUM_REMINDERS]
,[PAYMENT_CODE]
,[CYCLE_GROUP]
,ODS_START_DATE
FROM [DBO].[AR_DEBTOR]
{% if is_incremental() %}
-- this filter will only be applied on an incremental run
WHERE ODS_START_DATE > (select max(ODS_START_DATE) from {{ this }})
{% endif %} Incremental Run
Versions - dbt =1.1.2, sqlserver=1.1.1, synapse = 1.1.0 |
Hi I've been able to fix this issue by overriding the sqlserver__make_temp_relation with a synapse version of this macro that does not use a temp table when the distribution type is REPLICATE. Create a new macro in the macros folder of your project and use this code.
To permanently fix this in this synapse adapter, this logic should be added to the relation.sql file. |
PR #138 You can now create seed tables with different distribution and index strategy by providing required confiuration in dbt_project.yml file. The default choice is REPLICATE disttribution and HEAP (no indexing). If you want to override this configuration, the following sample should help.
Create a new context "seeds:" at the root followed by project name and seed name. In this case the project name is jaffle_shop and seeds are raw_customers and raw_payments. Provide index and distribution values using index and dist keys. Use replicate, round_robin, hash({column name}) as a value. Example: dist: replicate. The raw_customers seed table will be replicated a table. For hash distribution, the user need to provide the vaule HASH(payment_method). Example: dist: hash(payment_method) To specific index, index as a key and CLUSTERED INDEX({Column1, Column2}), HEAP, CLUSTERED COLUMNSTORE INDEX as a value. Example: index: HEAP. The raw_customers seed table will use heap index strategy. For clustered index, the user need to provide one or more columns to create clustered index on. Example: index: CLUSTERED INDEX(id,order_id). The default value of index and distribution can also be set for all seeds under project name. |
Is this going to be incorporated into the adapter, and if so any thoughts on when? |
Hey, I just tried this on dbt synapse 1.8 and I think the issue is closed as it no longer occurs on latest version (I deleted the local macro I've been running for ages for this and it still worked). However this is because the intermediate relation is now a view which does cause it's own problems (specifically that a table can be missing for a while as there's now a CTAS from a view which can be slow.). I will leave the intermediate macro in our instance as I suspect it may still come in handy, but techincally I think this can be closed.
Example Table tested ^^ Behaviour:
|
When running incremental models on Synpase Replicated tables an error is thrown:
[42000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Option 'REPLICATE User Temp Table' is not supported in this version of SQL Server. (104458) (SQLExecDirectW)
It appears the fix is to override the
sqlserver__make_temp_relation
macro and remove the # ~ (temp table identifier) from{% set tmp_identifier = '#' ~ base_relation.identifier ~ suffix %}
The text was updated successfully, but these errors were encountered: