fix(history): optimistic array modifications #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark Analysis Report✅ No significant performance changes detected Threshold: 5% change Updated: 2025-11-28T01:18:44.517Z |
vladar
approved these changes
Nov 27, 2025
pavelglac
deleted the
user/pavelglac/fix-optimistic-updates-with-array-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes nodeDiff from SerializedHistory. It was causing weird behavior in devtools when the tool was not able to display array changes because they are of type ObjectDifference.
It is not necessary to have changes and nodiffs for developers. We can transform nodediffs to the same (at least very similar) changes we are using for regular updates. This also simplify the logic from stripping data from history.