Add inherited capabilities to JSON metaModel #2201
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Actually the metaModel.json is generated from the TypeScript code. Instead of changing the code we would need to update the generator to emit the information. |
Author
|
Is that the source of truth in question https://github.com/microsoft/vscode-languageserver-node/blob/main/protocol/src/common/protocol.ts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some language bindings rely on the JSON mode to determine whether a given method is callable. It would therefore be helpful to explicitly reference the inherited capability in the JSON definition, rather than mention it only in the human-readable documentation.