cleanup

Author: gargsaumya

main.py

@@ -5,21 +5,17 @@
 
 setup_logging('stdout')
 
-# conn_str = os.getenv("DB_CONNECTION_STRING")
-conn_str = "Server=Saumya;DATABASE=master;UID=sa;PWD=HappyPass1234;Trust_Connection=yes;TrustServerCertificate=yes;"
-
+conn_str = os.getenv("DB_CONNECTION_STRING")
 conn = connect(conn_str)
 
 # conn.autocommit = True
 
 cursor = conn.cursor()
-cursor.execute("DROP TABLE IF EXISTS test_decimal")
-cursor.execute("CREATE TABLE test_decimal (val DECIMAL(38, 10))")
-cursor.execute("INSERT INTO test_decimal (val) VALUES (?)", (decimal.Decimal('1234567890.1234567890'),))
-cursor.commit()
-print("Inserted value")
-cursor.execute("SELECT val FROM test_decimal")
-row = cursor.fetchone()
-print(f"Fetched value: {row[0]}")
-print(f"Type of fetched value: {type(row[0])}")
-assert row[0] == decimal.Decimal('1234567890.1234567890')
+cursor.execute("SELECT database_id, name from sys.databases;")
+rows = cursor.fetchall()
+
+for row in rows:
+    print(f"Database ID: {row[0]}, Name: {row[1]}")
+
+cursor.close()
+conn.close()

mssql_python/cursor.py

@@ -216,7 +216,6 @@ def _get_numeric_data(self, param):
             precision = exponent * -1
             scale = exponent * -1
 
-        # TODO: Revisit this check, do we want this restriction?
         if precision > 38:
             raise ValueError(
                 "Precision of the numeric value is too high - "
@@ -231,30 +230,24 @@ def _get_numeric_data(self, param):
         # strip decimal point from param & convert the significant digits to integer
         # Ex: 12.34 ---> 1234
         int_str = ''.join(str(d) for d in digits_tuple)
-
-        # Apply exponent to get the unscaled integer string
         if exponent > 0:
             int_str = int_str + ('0' * exponent)
         elif exponent < 0:
-            # if exponent negative and abs(exponent) > num_digits we padded precision above
-            # for the integer representation we pad leading zeros
             if -exponent > num_digits:
                 int_str = ('0' * (-exponent - num_digits)) + int_str
 
-        # Edge: if int_str becomes empty (Decimal('0')), make "0"
         if int_str == '':
             int_str = '0'
 
-        # Convert decimal base-10 string -> python int, then to 16 little-endian bytes
-        big_int = int(int_str)  # Python big int is arbitrary precision
+        # Convert decimal base-10 string to python int, then to 16 little-endian bytes
+        big_int = int(int_str)
         byte_array = bytearray(16)  # SQL_MAX_NUMERIC_LEN
         for i in range(16):
             byte_array[i] = big_int & 0xFF
             big_int >>= 8
             if big_int == 0:
                 break
 
-        # numeric_data.val should be bytes (pybindable). Ensure a bytes object of length 16.
         numeric_data.val = bytes(byte_array)
         return numeric_data
 

mssql_python/pybind/ddbc_bindings.cpp

@@ -2052,8 +2052,8 @@ SQLRETURN BindParameterArray(SQLHANDLE hStmt,
                             throw std::runtime_error(MakeParamMismatchErrorStr(info.paramCType, paramIndex));
                         }
                         NumericData decimalParam = element.cast<NumericData>();
-                        LOG("Received numeric parameter at [%zu]: precision=%d, scale=%d, sign=%d, val=%lld",
-                            i, decimalParam.precision, decimalParam.scale, decimalParam.sign, decimalParam.val);
+                        LOG("Received numeric parameter at [%zu]: precision=%d, scale=%d, sign=%d, val=%s",
+                            i, decimalParam.precision, decimalParam.scale, decimalParam.sign, decimalParam.val.c_str());
                         SQL_NUMERIC_STRUCT& target = numericArray[i];
                         std::memset(&target, 0, sizeof(SQL_NUMERIC_STRUCT));
                         target.precision = decimalParam.precision;