Resolving comments

Author: jahnvi480

mssql_python/connection.py

@@ -152,8 +152,8 @@ def __init__(self, connection_str: str = "", autocommit: bool = False, attrs_bef
         # Initialize encoding settings with defaults for Python 3
         # Python 3 only has str (which is Unicode), so we use utf-16le by default
         self._encoding_settings = {
-            'encoding': 'utf-16le',
-            'ctype': ConstantsDDBC.SQL_WCHAR.value
+            'encoding': 'utf-8',
+            'ctype': ConstantsDDBC.SQL_CHAR.value
         }
 
         # Initialize decoding settings with Python 3 defaults
@@ -373,9 +373,10 @@ def setencoding(self, encoding=None, ctype=None):
 
         # Enforce UTF-16LE for SQL_WCHAR
         if ctype == ConstantsDDBC.SQL_WCHAR.value and encoding not in UTF16_ENCODINGS:
-            raise ValueError(
-                f"SQL_WCHAR must use UTF-16LE encoding. '{encoding}' is not supported for SQL_WCHAR. "
-                f"Use SQL_CHAR if you need to use '{encoding}' encoding."
+            raise ProgrammingError(
+                driver_error=f"SQL_WCHAR requires UTF-16LE encoding",
+                ddbc_error=f"SQL_WCHAR must use UTF-16LE encoding. '{encoding}' is not supported for SQL_WCHAR. "
+                          f"Use SQL_CHAR if you need to use '{encoding}' encoding."
             )
 
         # Store the encoding settings
@@ -462,9 +463,9 @@ def setdecoding(self, sqltype, encoding=None, ctype=None):
         # For SQL_WCHAR and SQL_WMETADATA, enforce UTF-16LE encoding and SQL_WCHAR ctype
         if sqltype in (ConstantsDDBC.SQL_WCHAR.value, SQL_WMETADATA):
             if encoding is not None and encoding.lower() not in UTF16_ENCODINGS:
-                raise ValueError(
-                    f"SQL_WCHAR and SQL_WMETADATA must use UTF-16LE encoding. '{encoding}' is not supported. "
-                    f"Custom encodings are only supported for SQL_CHAR."
+                raise ProgrammingError(
+                    driver_error=f"SQL_WCHAR and SQL_WMETADATA must use UTF-16LE encoding. '{encoding}' is not supported.",
+                    ddbc_error=f"Custom encodings are only supported for SQL_CHAR. '{encoding}' is not valid for SQL_WCHAR or SQL_WMETADATA."
                 )
             # Always enforce UTF-16LE for wide character types
             encoding = 'utf-16le'

mssql_python/cursor.py

@@ -117,13 +117,13 @@ def _get_encoding_settings(self):
             except:
                 # Return default encoding settings if there's an error
                 return {
-                    'encoding': 'utf-16le', 
-                    'ctype': ddbc_sql_const.SQL_WCHAR.value
+                    'encoding': 'utf-8', 
+                    'ctype': ddbc_sql_const.SQL_CHAR.value
                 }
         # Return default encoding settings if getencoding is not available
         return {
-            'encoding': 'utf-16le',
-            'ctype': ddbc_sql_const.SQL_WCHAR.value
+            'encoding': 'utf-8',
+            'ctype': ddbc_sql_const.SQL_CHAR.value
         }
 
     def _get_decoding_settings(self, sql_type):