Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Enhance SEA pointer validation #400

Open
makubacki opened this issue Feb 13, 2025 · 4 comments
Open

[Feature]: Enhance SEA pointer validation #400

makubacki opened this issue Feb 13, 2025 · 4 comments
Assignees
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:medium Important with a moderate impact

Comments

@makubacki
Copy link
Member

Feature Overview

Currently the pointer size and whether the pointer is null are checked. This issue tracks adding more checks to verify pointer correctness. It is expected that those be discussed further in the issue until an implementation plan is agreed upon and then an owner is assigned.

Solution Overview

Consider whether to add checks like verifying the pointer is to an address within TSEG and/or MSEG and other constraints.

Alternatives Considered

No response

Urgency

Medium

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

No response

@makubacki makubacki added state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal labels Feb 13, 2025
@github-actions github-actions bot added state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps urgency:medium Important with a moderate impact state:needs-owner Needs an issue owner to be assigned labels Feb 13, 2025
@makubacki
Copy link
Member Author

makubacki commented Feb 19, 2025

#399 included some initial checks for the pointer entry type, therefore I'm assigning to @Javagedes to close out this issue.

The current validation checks the pointer size and whether the pointer is null. This issue still needs to capture any additional requirements so they can be implemented.

@kuqin12, do you have any additional requirements? Would we expect all pointers to either point within a specific area for example?

@makubacki makubacki removed the state:needs-owner Needs an issue owner to be assigned label Feb 19, 2025
@Javagedes
Copy link
Contributor

From offline discussion:

  1. Create new entry extension for the Pointer validation type. Extension includes a single field to indicate if the pointer should point into MSEG or not (And some reserved data for alignment)
  2. Default value is false, indicating the pointer will NOT point to an area in MSEG. Overrideable via config file
  3. Outside of the rule, do a general check to ensure MSEG is readonly (And @kuqin12 will add code to lock it).

@kuqin12
Copy link
Contributor

kuqin12 commented Feb 19, 2025 via email

@Javagedes
Copy link
Contributor

#406 Added the bulk of this issue. Once kunqin12 Updates SEA to have MSEG be read only, I will add a final change to validate MSEG is in-fact read only in PeCoffImageDiffValidation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

3 participants