Roll other remaining commits

Author: agg23

playwright/_impl/_browser_context.py

@@ -88,6 +88,7 @@
 
 class BrowserContext(ChannelOwner):
     Events = SimpleNamespace(
+        # Deprecated in v1.56, never emitted anymore.
         BackgroundPage="backgroundpage",
         Close="close",
         Console="console",
@@ -117,7 +118,6 @@ def __init__(
         self._timeout_settings = TimeoutSettings(None)
         self._owner_page: Optional[Page] = None
         self._options: Dict[str, Any] = initializer["options"]
-        self._background_pages: Set[Page] = set()
         self._service_workers: Set[Worker] = set()
         self._base_url: Optional[str] = self._options.get("baseURL")
         self._videos_dir: Optional[str] = self._options.get("recordVideo")
@@ -149,10 +149,6 @@ def __init__(
                 )
             ),
         )
-        self._channel.on(
-            "backgroundPage",
-            lambda params: self._on_background_page(from_channel(params["page"])),
-        )
 
         self._channel.on(
             "serviceWorker",
@@ -658,10 +654,6 @@ def expect_page(
     ) -> EventContextManagerImpl[Page]:
         return self.expect_event(BrowserContext.Events.Page, predicate, timeout)
 
-    def _on_background_page(self, page: Page) -> None:
-        self._background_pages.add(page)
-        self.emit(BrowserContext.Events.BackgroundPage, page)
-
     def _on_service_worker(self, worker: Worker) -> None:
         worker._context = self
         self._service_workers.add(worker)
@@ -736,7 +728,7 @@ def _on_response(self, response: Response, page: Optional[Page]) -> None:
 
     @property
     def background_pages(self) -> List[Page]:
-        return list(self._background_pages)
+        return []
 
     @property
     def service_workers(self) -> List[Worker]:

playwright/_impl/_page.py

@@ -345,8 +345,6 @@ def _on_close(self) -> None:
         self._is_closed = True
         if self in self._browser_context._pages:
             self._browser_context._pages.remove(self)
-        if self in self._browser_context._background_pages:
-            self._browser_context._background_pages.remove(self)
         self._dispose_har_routers()
         self.emit(Page.Events.Close, self)
 

tests/async/test_page_aria_snapshot.py

@@ -204,3 +204,13 @@ async def test_should_snapshot_with_restored_contain_mode_inside_deep_equal(
               - listitem: 1.1
       """,
     )
+
+
+async def test_match_values_both_against_regex_and_string(page: Page) -> None:
+    await page.set_content('<a href="/auth?r=/">Log in</a>')
+    await expect(page.locator("body")).to_match_aria_snapshot(
+        """
+        - link "Log in":
+          - /url: /auth?r=/
+      """,
+    )