Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some kernel return codes are always corrupted for DropReason #1466

Open
rectified95 opened this issue Mar 24, 2025 · 0 comments · May be fixed by #1458
Open

Some kernel return codes are always corrupted for DropReason #1466

rectified95 opened this issue Mar 24, 2025 · 0 comments · May be fixed by #1458

Comments

@rectified95
Copy link
Contributor

A few instances of passing a negative return code to an unsigned map key. THis always overflows, and the resulting metric value is partially meaningless.
Eg.: https://github.com/microsoft/retina/blob/main/pkg/plugin/dropreason/_cprog/drop_reason.c#L310

Related to #1451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Retina Triage Board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(basic-metrics): Use fexit instead of kprobes for DropReason rectified95/retina
1 participant
@rectified95