Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 7, 2025

Summary

Projects using @rushstack/heft-node-rig that output to lib-dts (TypeScript declarations) or lib-esm (ES modules) directories were not having these directories cleaned during builds. Updated the rig's default cleanFiles configuration to include these standard output directories.

Details

Added lib-dts and lib-esm to the includeGlobs array in rigs/heft-node-rig/profiles/default/config/heft.json. This aligns with the pattern already used in heft-vscode-extension-rig and matches common TypeScript output directory conventions used throughout the monorepo.

Generated Rush change file with patch version bump as required by the monorepo's versioning workflow.

How it was tested

Validated JSON syntax and verified consistency with existing rig configurations. Generated Rush change file successfully using rush change command.

Impacted documentation

None. This is an internal configuration change to standard build artifact cleanup.

Original prompt

Add lib-dts and lib-esm to the cleanFiles glob in @rushstack/heft-node-rig

"cleanFiles": [{ "includeGlobs": ["dist", "lib", "lib-commonjs"] }],


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add lib-dts and lib-esm to cleanFiles glob [heft-node-rig] Add lib-dts and lib-esm to cleanFiles glob Nov 7, 2025
Copilot AI requested a review from dmichon-msft November 7, 2025 23:19
Copilot finished work on behalf of dmichon-msft November 7, 2025 23:19
Copy link
Contributor

@dmichon-msft dmichon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, looks good.

@dmichon-msft
Copy link
Contributor

@copilot Run rush change --no-fetch --bulk --bump-type patch --message "Include lib-dts and lib-esm folders in default files to clean" to generate the necessary change file.

Copy link
Contributor Author

Copilot AI commented Nov 7, 2025

@copilot Run rush change --no-fetch --bulk --bump-type patch --message "Include lib-dts and lib-esm folders in default files to clean" to generate the necessary change file.

Done. Generated change file in commit 58e9fac.

Copilot AI requested a review from dmichon-msft November 7, 2025 23:52
Copilot finished work on behalf of dmichon-msft November 7, 2025 23:52
@dmichon-msft dmichon-msft marked this pull request as ready for review November 8, 2025 01:18
@iclanton iclanton moved this from Needs triage to In Progress in Bug Triage Nov 10, 2025
@iclanton iclanton merged commit 23f78ab into main Nov 10, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Closed in Bug Triage Nov 10, 2025
@iclanton iclanton deleted the copilot/add-lib-dts-lib-esm-cleanfiles branch November 10, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants