Skip to content

Commit ce6bb7a

Browse files
weiguangli-ioclaude
andcommitted
Fix mypy type error: handle None parameter names
Fix type checking error where param.name could be None when used as dict key. Added None checks before using param.name in both Google AI and Vertex AI utils to satisfy mypy strict type requirements. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent dba1cf8 commit ce6bb7a

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

  • python/semantic_kernel/connectors/ai/google

python/semantic_kernel/connectors/ai/google/google_ai/services/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,12 +152,14 @@ def kernel_function_metadata_to_google_ai_function_call_format(metadata: KernelF
152152
if metadata.parameters:
153153
properties = {}
154154
for param in metadata.parameters:
155+
if param.name is None:
156+
continue
155157
prop_schema = sanitize_schema_for_google_ai(param.schema_data) if param.schema_data else param.schema_data
156158
properties[param.name] = prop_schema
157159
parameters = {
158160
"type": "object",
159161
"properties": properties,
160-
"required": [p.name for p in metadata.parameters if p.is_required],
162+
"required": [p.name for p in metadata.parameters if p.is_required and p.name is not None],
161163
}
162164
return {
163165
"name": metadata.custom_fully_qualified_name(GEMINI_FUNCTION_NAME_SEPARATOR),

python/semantic_kernel/connectors/ai/google/vertex_ai/services/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,8 @@ def kernel_function_metadata_to_vertex_ai_function_call_format(metadata: KernelF
141141
properties: dict[str, Any] = {}
142142
if metadata.parameters:
143143
for param in metadata.parameters:
144+
if param.name is None:
145+
continue
144146
prop_schema = sanitize_schema_for_google_ai(param.schema_data) if param.schema_data else param.schema_data
145147
properties[param.name] = prop_schema
146148
return FunctionDeclaration(
@@ -149,7 +151,7 @@ def kernel_function_metadata_to_vertex_ai_function_call_format(metadata: KernelF
149151
parameters={
150152
"type": "object",
151153
"properties": properties,
152-
"required": [p.name for p in metadata.parameters if p.is_required],
154+
"required": [p.name for p in metadata.parameters if p.is_required and p.name is not None],
153155
},
154156
)
155157

0 commit comments

Comments
 (0)