Narrow symlink-setup exception handling in plugin tests

SergeyMenshykh · Copilot · SergeyMenshykh · commit fd2b529301f8 · 2026-06-25T09:54:57.000+01:00
Catch only the privilege exceptions (IOException/UnauthorizedAccessException) when creating symbolic links and remove the File.Exists/Directory.Exists guards, so genuine test-setup failures surface instead of being masked. The early return is retained only for environments (e.g. Windows build agents) that don't permit symbolic link creation.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/dotnet/src/Plugins/Plugins.UnitTests/Core/FileIOPluginTests.cs b/dotnet/src/Plugins/Plugins.UnitTests/Core/FileIOPluginTests.cs
@@ -164,17 +164,9 @@ public async Task ItCannotReadThroughSymlinkOutsideAllowedFoldersAsync()
             {
                 File.CreateSymbolicLink(symlinkPath, outsideFile);
             }
-            catch (IOException)
-            {
-                return;
-            }
-            catch (UnauthorizedAccessException)
-            {
-                return;
-            }
-
-            if (!File.Exists(symlinkPath))
+            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
             {
+                // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
                 return;
             }
 
@@ -209,17 +201,9 @@ public async Task ItCannotWriteThroughSymlinkOutsideAllowedFoldersAsync()
             {
                 File.CreateSymbolicLink(symlinkPath, outsideFile);
             }
-            catch (IOException)
-            {
-                return;
-            }
-            catch (UnauthorizedAccessException)
-            {
-                return;
-            }
-
-            if (!File.Exists(symlinkPath))
+            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
             {
+                // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
                 return;
             }
 
@@ -257,12 +241,9 @@ public async Task ItCannotWriteThroughDanglingSymlinkOutsideAllowedFoldersAsync(
             {
                 File.CreateSymbolicLink(symlinkPath, outsideFile);
             }
-            catch (IOException)
-            {
-                return;
-            }
-            catch (UnauthorizedAccessException)
+            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
             {
+                // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
                 return;
             }
 
diff --git a/dotnet/src/Plugins/Plugins.UnitTests/Core/PathUtilitiesTests.cs b/dotnet/src/Plugins/Plugins.UnitTests/Core/PathUtilitiesTests.cs
@@ -72,14 +72,9 @@ public void GetSafeFullPathResolvesFileSymlink()
         {
             File.CreateSymbolicLink(symlinkPath, targetFile);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-
-        if (!File.Exists(symlinkPath))
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
@@ -109,14 +104,9 @@ public void GetSafeFullPathResolvesSymlinkPointingOutsideDirectory()
         {
             File.CreateSymbolicLink(symlinkInAllowedDir, sensitiveFile);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-
-        if (!File.Exists(symlinkInAllowedDir))
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
@@ -149,14 +139,9 @@ public void GetSafeFullPathResolvesDirectorySymlink()
         {
             Directory.CreateSymbolicLink(symlinkDir, outsideDir);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-
-        if (!Directory.Exists(symlinkDir))
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
@@ -188,14 +173,9 @@ public void GetSafeFullPathResolvesNestedDirectorySymlink()
         {
             Directory.CreateSymbolicLink(symlinkDir, outsideDir);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-
-        if (!Directory.Exists(symlinkDir))
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
@@ -224,14 +204,9 @@ public void GetSafeFullPathResolvesChainedSymlinks()
             File.CreateSymbolicLink(link2, realTarget);
             File.CreateSymbolicLink(link1, link2);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-
-        if (!File.Exists(link1))
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
@@ -253,13 +228,9 @@ public void GetSafeFullPathResolvesDanglingSymlinkTarget()
         {
             File.CreateSymbolicLink(symlinkPath, missingTarget);
         }
-        catch (IOException)
-        {
-            // Symlink creation requires elevated privileges on Windows
-            return;
-        }
-        catch (UnauthorizedAccessException)
+        catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
         {
+            // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
             return;
         }
 
diff --git a/dotnet/src/Plugins/Plugins.UnitTests/Core/SessionsPythonPluginTests.cs b/dotnet/src/Plugins/Plugins.UnitTests/Core/SessionsPythonPluginTests.cs
@@ -493,17 +493,9 @@ public async Task ItShouldDenyDownloadThroughSymlinkOutsideAllowedDirectoriesAsy
             {
                 File.CreateSymbolicLink(symlinkPath, outsideFile);
             }
-            catch (IOException)
-            {
-                return;
-            }
-            catch (UnauthorizedAccessException)
-            {
-                return;
-            }
-
-            if (!File.Exists(symlinkPath))
+            catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
             {
+                // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).
                 return;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -164,17 +164,9 @@ public async Task ItCannotReadThroughSymlinkOutsideAllowedFoldersAsync()`
`164`	`164`	`{`
`165`	`165`	`File.CreateSymbolicLink(symlinkPath, outsideFile);`
`166`	`166`	`}`
`167`		`- catch (IOException)`
`168`		`- {`
`169`		`- return;`
`170`		`- }`
`171`		`- catch (UnauthorizedAccessException)`
`172`		`- {`
`173`		`- return;`
`174`		`- }`
`175`		`-`
`176`		`- if (!File.Exists(symlinkPath))`
	`167`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`177`	`168`	`{`
	`169`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`178`	`170`	`return;`
`179`	`171`	`}`
`180`	`172`
`@@ -209,17 +201,9 @@ public async Task ItCannotWriteThroughSymlinkOutsideAllowedFoldersAsync()`
`209`	`201`	`{`
`210`	`202`	`File.CreateSymbolicLink(symlinkPath, outsideFile);`
`211`	`203`	`}`
`212`		`- catch (IOException)`
`213`		`- {`
`214`		`- return;`
`215`		`- }`
`216`		`- catch (UnauthorizedAccessException)`
`217`		`- {`
`218`		`- return;`
`219`		`- }`
`220`		`-`
`221`		`- if (!File.Exists(symlinkPath))`
	`204`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`222`	`205`	`{`
	`206`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`223`	`207`	`return;`
`224`	`208`	`}`
`225`	`209`
`@@ -257,12 +241,9 @@ public async Task ItCannotWriteThroughDanglingSymlinkOutsideAllowedFoldersAsync(`
`257`	`241`	`{`
`258`	`242`	`File.CreateSymbolicLink(symlinkPath, outsideFile);`
`259`	`243`	`}`
`260`		`- catch (IOException)`
`261`		`- {`
`262`		`- return;`
`263`		`- }`
`264`		`- catch (UnauthorizedAccessException)`
	`244`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`265`	`245`	`{`
	`246`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`266`	`247`	`return;`
`267`	`248`	`}`
`268`	`249`
Original file line number	Diff line number	Diff line change
`@@ -72,14 +72,9 @@ public void GetSafeFullPathResolvesFileSymlink()`
`72`	`72`	`{`
`73`	`73`	`File.CreateSymbolicLink(symlinkPath, targetFile);`
`74`	`74`	`}`
`75`		`- catch (IOException)`
`76`		`- {`
`77`		`- // Symlink creation requires elevated privileges on Windows`
`78`		`- return;`
`79`		`- }`
`80`		`-`
`81`		`- if (!File.Exists(symlinkPath))`
	`75`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`82`	`76`	`{`
	`77`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`83`	`78`	`return;`
`84`	`79`	`}`
`85`	`80`
`@@ -109,14 +104,9 @@ public void GetSafeFullPathResolvesSymlinkPointingOutsideDirectory()`
`109`	`104`	`{`
`110`	`105`	`File.CreateSymbolicLink(symlinkInAllowedDir, sensitiveFile);`
`111`	`106`	`}`
`112`		`- catch (IOException)`
`113`		`- {`
`114`		`- // Symlink creation requires elevated privileges on Windows`
`115`		`- return;`
`116`		`- }`
`117`		`-`
`118`		`- if (!File.Exists(symlinkInAllowedDir))`
	`107`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`119`	`108`	`{`
	`109`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`120`	`110`	`return;`
`121`	`111`	`}`
`122`	`112`
`@@ -149,14 +139,9 @@ public void GetSafeFullPathResolvesDirectorySymlink()`
`149`	`139`	`{`
`150`	`140`	`Directory.CreateSymbolicLink(symlinkDir, outsideDir);`
`151`	`141`	`}`
`152`		`- catch (IOException)`
`153`		`- {`
`154`		`- // Symlink creation requires elevated privileges on Windows`
`155`		`- return;`
`156`		`- }`
`157`		`-`
`158`		`- if (!Directory.Exists(symlinkDir))`
	`142`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`159`	`143`	`{`
	`144`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`160`	`145`	`return;`
`161`	`146`	`}`
`162`	`147`
`@@ -188,14 +173,9 @@ public void GetSafeFullPathResolvesNestedDirectorySymlink()`
`188`	`173`	`{`
`189`	`174`	`Directory.CreateSymbolicLink(symlinkDir, outsideDir);`
`190`	`175`	`}`
`191`		`- catch (IOException)`
`192`		`- {`
`193`		`- // Symlink creation requires elevated privileges on Windows`
`194`		`- return;`
`195`		`- }`
`196`		`-`
`197`		`- if (!Directory.Exists(symlinkDir))`
	`176`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`198`	`177`	`{`
	`178`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`199`	`179`	`return;`
`200`	`180`	`}`
`201`	`181`
`@@ -224,14 +204,9 @@ public void GetSafeFullPathResolvesChainedSymlinks()`
`224`	`204`	`File.CreateSymbolicLink(link2, realTarget);`
`225`	`205`	`File.CreateSymbolicLink(link1, link2);`
`226`	`206`	`}`
`227`		`- catch (IOException)`
`228`		`- {`
`229`		`- // Symlink creation requires elevated privileges on Windows`
`230`		`- return;`
`231`		`- }`
`232`		`-`
`233`		`- if (!File.Exists(link1))`
	`207`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`234`	`208`	`{`
	`209`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`235`	`210`	`return;`
`236`	`211`	`}`
`237`	`212`
`@@ -253,13 +228,9 @@ public void GetSafeFullPathResolvesDanglingSymlinkTarget()`
`253`	`228`	`{`
`254`	`229`	`File.CreateSymbolicLink(symlinkPath, missingTarget);`
`255`	`230`	`}`
`256`		`- catch (IOException)`
`257`		`- {`
`258`		`- // Symlink creation requires elevated privileges on Windows`
`259`		`- return;`
`260`		`- }`
`261`		`- catch (UnauthorizedAccessException)`
	`231`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`262`	`232`	`{`
	`233`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`263`	`234`	`return;`
`264`	`235`	`}`
`265`	`236`
Original file line number	Diff line number	Diff line change
`@@ -493,17 +493,9 @@ public async Task ItShouldDenyDownloadThroughSymlinkOutsideAllowedDirectoriesAsy`
`493`	`493`	`{`
`494`	`494`	`File.CreateSymbolicLink(symlinkPath, outsideFile);`
`495`	`495`	`}`
`496`		`- catch (IOException)`
`497`		`- {`
`498`		`- return;`
`499`		`- }`
`500`		`- catch (UnauthorizedAccessException)`
`501`		`- {`
`502`		`- return;`
`503`		`- }`
`504`		`-`
`505`		`- if (!File.Exists(symlinkPath))`
	`496`	`+ catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)`
`506`	`497`	`{`
	`498`	`+ // Skip: this environment does not permit symbolic link creation (e.g., Windows without the required privilege).`
`507`	`499`	`return;`
`508`	`500`	`}`
`509`	`501`