Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RegisterTestFramework adapterFactory parameter #2443

Open
nohwnd opened this issue Feb 26, 2024 · 0 comments
Open

Rename RegisterTestFramework adapterFactory parameter #2443

nohwnd opened this issue Feb 26, 2024 · 0 comments
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Breaking ‼️
Milestone
Platform 2.0

Comments

@nohwnd
Copy link
Member

nohwnd commented Feb 26, 2024 •
edited
Loading

Rename adapterFactory parameter in Microsoft.Testing.Platform.Builder.ITestApplicationBuilder.RegisterTestFramework public api to frameworkFactory.

The naming is leaking the details of what we do for MSTest in the specific VSTest compatible implementation, but does not fit the generic interface.

This is a code breaking change for calls that use the name of the parameter.
@nohwnd nohwnd added the Area: MTP Belongs to the Microsoft.Testing.Platform core library label Feb 26, 2024
@Evangelink Evangelink added this to the 4.0.0 milestone Mar 2, 2024
@Evangelink Evangelink modified the milestones: 4.0.0, Platform 2.0 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: MTP Belongs to the Microsoft.Testing.Platform core library Breaking ‼️
Projects
None yet
Milestone
Platform 2.0
Development

No branches or pull requests
2 participants
@nohwnd @Evangelink