Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --list-projects in new dotnet test experience #5197

Open
Youssef1313 opened this issue Mar 9, 2025 · 8 comments
Open

Allow --list-projects in new dotnet test experience #5197

Youssef1313 opened this issue Mar 9, 2025 · 8 comments
Labels
External: dotnet test `dotnet test` integration Needs: Design Needs research and proposal for how the feature will be implemented.

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Mar 9, 2025

This is a feature request to allow --list-projects when running the new dotnet test experience on a solution. It makes users more confident that their setup is correct and that all intended test projects are correctly considered.

FYI @mariam-abdulla

@Youssef1313 Youssef1313 added the External: dotnet test `dotnet test` integration label Mar 9, 2025
@Youssef1313
Copy link
Member Author

This is an idea that came to mind, but I'm not sure how much value it is. We may need to discuss and/or wait for user feedback.

@nohwnd
Copy link
Member

nohwnd commented Mar 10, 2025

My suggestion is to keep this under --list-tests, we already show the projects there, we could add a list of projects + test counts to the end, which would be the functionality.

it could also be an option for --list-tests, e.g. --list-tests --output minimal

@Youssef1313
Copy link
Member Author

--list-tests --output minimal

We already have --output command line option. It may be confusing if we use that for two different purposes. Also, I think listing the projects will be a feature of SDK, while list-tests is a feature of MTP. --output is also an option of MTP. My understanding is that options that are recognized by SDK will not be passed down to MTP as well, and I'd try to avoid special casing that for specific options.

@nohwnd
Copy link
Member

nohwnd commented Mar 10, 2025

Okay so not --output, but I would still keep this as part of --list-tests. This is already understood by dotnet test, and you probably want to do full discovery to make sure stuff works.

@Youssef1313
Copy link
Member Author

Youssef1313 commented Mar 10, 2025

@nohwnd --list-tests is not understood by dotnet test for the new experience AFAIK. It's currently just passed down to the test executable.

and you probably want to do full discovery to make sure stuff works.

For the purpose of listing only the projects, why would I do the full discovery?

@mariam-abdulla
Copy link
Contributor

This is a feature request to allow --list-projects when running the new dotnet test experience on a solution. It makes users more confident that their setup is correct and that all intended test projects are correctly considered.

FYI @mariam-abdulla

We are passing --list-tests as an unrecognized token (because the test application does the work), we do check for its existence in dotnet sdk because the UX needs that.
I find Youssef's idea good, but let's wait for feedback from the users.

@Youssef1313 Youssef1313 added the Needs: Design Needs research and proposal for how the feature will be implemented. label Mar 10, 2025
@nohwnd
Copy link
Member

nohwnd commented Mar 10, 2025

Image

This is the current experience, to me it is 90% there.

@Evangelink
Copy link
Member

Although I like the idea to show test assemblies, I think it fits better with having ways to change format of --list-tests. Couple of related requests: #3527, #3221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External: dotnet test `dotnet test` integration Needs: Design Needs research and proposal for how the feature will be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants