dts emit is pending when dts errors are pending, do not clean emit diagnostics if dts errors are not pending

Author: sheetalkamat

internal/incremental/snapshot.go

@@ -96,7 +96,7 @@ func getPendingEmitKind(emitKind FileEmitKind, oldEmitKind FileEmitKind) FileEmi
 	}
 	// If dts errors pending, add dts errors flag
 	if (diff & FileEmitKindDtsErrors) != 0 {
-		result |= emitKind & FileEmitKindDtsErrors
+		result |= emitKind & FileEmitKindAllDts
 	}
 	// If there is diff in Dts emit, pending emit is dts emit flags
 	if (diff & FileEmitKindAllDtsEmit) != 0 {
@@ -239,7 +239,9 @@ func (s *snapshot) addFileToChangeSet(filePath tspath.Path) {
 func (s *snapshot) addFileToAffectedFilesPendingEmit(filePath tspath.Path, emitKind FileEmitKind) {
 	existingKind, _ := s.affectedFilesPendingEmit.Load(filePath)
 	s.affectedFilesPendingEmit.Store(filePath, existingKind|emitKind)
-	s.emitDiagnosticsPerFile.Delete(filePath)
+	if emitKind&FileEmitKindDtsErrors != 0 {
+		s.emitDiagnosticsPerFile.Delete(filePath)
+	}
 	s.buildInfoEmitPending.Store(true)
 }
 

testdata/baselines/reference/tsbuild/noEmit/dts-errors-with-declaration-enable-changes-with-incremental-as-modules.js

@@ -256,7 +256,7 @@ Signatures::
 Edit [2]:: With declaration and declarationMap noEmit - Should report errors
 
 tsgo -b -v --noEmit --declaration --declarationMap
-ExitStatus:: Success
+ExitStatus:: DiagnosticsPresent_OutputsSkipped
 Output::
 [HH:MM:SS AM] Projects in this build: 
     * tsconfig.json
@@ -265,8 +265,20 @@ Output::
 
 [HH:MM:SS AM] Building project 'tsconfig.json'...
 
+a.ts:1:14 - error TS4094: Property 'p' of exported anonymous class type may not be private or protected.
+
+1 export const a = class { private p = 10; };
+               ~
+
+  a.ts:1:14 - Add a type annotation to the variable a.
+    1 export const a = class { private p = 10; };
+                   ~
+
+
+Found 1 error in a.ts:1
+
 //// [/home/src/projects/project/tsconfig.tsbuildinfo] *modified* 
-{"version":"FakeTSVersion","root":[[2,3]],"fileNames":["lib.d.ts","./a.ts","./b.ts"],"fileInfos":[{"version":"8859c12c614ce56ba9a18e58384a198f-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ninterface SymbolConstructor {\n    (desc?: string | number): symbol;\n    for(name: string): symbol;\n    readonly toStringTag: symbol;\n}\ndeclare var Symbol: SymbolConstructor;\ninterface Symbol {\n    readonly [Symbol.toStringTag]: string;\n}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedNodeFormat":1},"9c1fc7106f3a21aadb5219db8b3209bc-export const a = class { private p = 10; };","907abc8137ceb88f0ddd6eccfa92d573-export const b = 10;"],"options":{"declaration":true,"declarationMap":true},"affectedFilesPendingEmit":[[2,49],[3,49]]}
+{"version":"FakeTSVersion","root":[[2,3]],"fileNames":["lib.d.ts","./a.ts","./b.ts"],"fileInfos":[{"version":"8859c12c614ce56ba9a18e58384a198f-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ninterface SymbolConstructor {\n    (desc?: string | number): symbol;\n    for(name: string): symbol;\n    readonly toStringTag: symbol;\n}\ndeclare var Symbol: SymbolConstructor;\ninterface Symbol {\n    readonly [Symbol.toStringTag]: string;\n}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedNodeFormat":1},"9c1fc7106f3a21aadb5219db8b3209bc-export const a = class { private p = 10; };","907abc8137ceb88f0ddd6eccfa92d573-export const b = 10;"],"options":{"declaration":true,"declarationMap":true},"emitDiagnosticsPerFile":[[2,[{"pos":13,"end":14,"code":4094,"category":1,"message":"Property 'p' of exported anonymous class type may not be private or protected.","relatedInformation":[{"pos":13,"end":14,"code":9027,"category":1,"message":"Add a type annotation to the variable a."}]}]]],"affectedFilesPendingEmit":[[2,49],[3,49]]}
 //// [/home/src/projects/project/tsconfig.tsbuildinfo.readable.baseline.txt] *modified* 
 {
   "version": "FakeTSVersion",
@@ -317,6 +329,29 @@ Output::
     "declaration": true,
     "declarationMap": true
   },
+  "emitDiagnosticsPerFile": [
+    [
+      "./a.ts",
+      [
+        {
+          "pos": 13,
+          "end": 14,
+          "code": 4094,
+          "category": 1,
+          "message": "Property 'p' of exported anonymous class type may not be private or protected.",
+          "relatedInformation": [
+            {
+              "pos": 13,
+              "end": 14,
+              "code": 9027,
+              "category": 1,
+              "message": "Add a type annotation to the variable a."
+            }
+          ]
+        }
+      ]
+    ]
+  ],
   "affectedFilesPendingEmit": [
     [
       "./a.ts",
@@ -335,31 +370,14 @@ Output::
       ]
     ]
   ],
-  "size": 1100
+  "size": 1390
 }
 
 tsconfig.json::
 SemanticDiagnostics::
 Signatures::
 
 
-Diff:: !!! Unexpected diff, please review and either fix or write explanation as expectedDiff !!!
---- nonIncremental.output.txt
-+++ incremental.output.txt
-@@ -1,12 +0,0 @@
--a.ts:1:14 - error TS4094: Property 'p' of exported anonymous class type may not be private or protected.
--
--1 export const a = class { private p = 10; };
--               ~
--
--  a.ts:1:14 - Add a type annotation to the variable a.
--    1 export const a = class { private p = 10; };
--                   ~
--
--
--Found 1 error in a.ts:1
--
-
 Edit [3]:: no change
 
 tsgo -b -v --noEmit
@@ -381,7 +399,7 @@ Output::
 [HH:MM:SS AM] Projects in this build: 
     * tsconfig.json
 
-[[90mHH:MM:SS AM[0m] Project 'tsconfig.json' is out of date because buildinfo file 'tsconfig.tsbuildinfo' indicates that some of the changes were not emitted
+[[90mHH:MM:SS AM[0m] Project 'tsconfig.json' is out of date because buildinfo file 'tsconfig.tsbuildinfo' indicates that program needs to report errors.
 
 [HH:MM:SS AM] Building project 'tsconfig.json'...
 

testdata/baselines/reference/tsbuild/noEmit/dts-errors-with-declaration-enable-changes-with-incremental.js

@@ -230,7 +230,7 @@ Signatures::
 Edit [2]:: With declaration and declarationMap noEmit - Should report errors
 
 tsgo -b -v --noEmit --declaration --declarationMap
-ExitStatus:: Success
+ExitStatus:: DiagnosticsPresent_OutputsSkipped
 Output::
 [HH:MM:SS AM] Projects in this build: 
     * tsconfig.json
@@ -239,8 +239,20 @@ Output::
 
 [HH:MM:SS AM] Building project 'tsconfig.json'...
 
+a.ts:1:7 - error TS4094: Property 'p' of exported anonymous class type may not be private or protected.
+
+1 const a = class { private p = 10; };
+        ~
+
+  a.ts:1:7 - Add a type annotation to the variable a.
+    1 const a = class { private p = 10; };
+            ~
+
+
+Found 1 error in a.ts:1
+
 //// [/home/src/projects/project/tsconfig.tsbuildinfo] *modified* 
-{"version":"FakeTSVersion","root":[2],"fileNames":["lib.d.ts","./a.ts"],"fileInfos":[{"version":"8859c12c614ce56ba9a18e58384a198f-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ninterface SymbolConstructor {\n    (desc?: string | number): symbol;\n    for(name: string): symbol;\n    readonly toStringTag: symbol;\n}\ndeclare var Symbol: SymbolConstructor;\ninterface Symbol {\n    readonly [Symbol.toStringTag]: string;\n}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedNodeFormat":1},{"version":"54435c7adb578d59d7e39dd2f567250e-const a = class { private p = 10; };","affectsGlobalScope":true,"impliedNodeFormat":1}],"options":{"declaration":true,"declarationMap":true},"affectedFilesPendingEmit":[[2,49]]}
+{"version":"FakeTSVersion","root":[2],"fileNames":["lib.d.ts","./a.ts"],"fileInfos":[{"version":"8859c12c614ce56ba9a18e58384a198f-/// <reference no-default-lib=\"true\"/>\ninterface Boolean {}\ninterface Function {}\ninterface CallableFunction {}\ninterface NewableFunction {}\ninterface IArguments {}\ninterface Number { toExponential: any; }\ninterface Object {}\ninterface RegExp {}\ninterface String { charAt: any; }\ninterface Array<T> { length: number; [n: number]: T; }\ninterface ReadonlyArray<T> {}\ninterface SymbolConstructor {\n    (desc?: string | number): symbol;\n    for(name: string): symbol;\n    readonly toStringTag: symbol;\n}\ndeclare var Symbol: SymbolConstructor;\ninterface Symbol {\n    readonly [Symbol.toStringTag]: string;\n}\ndeclare const console: { log(msg: any): void; };","affectsGlobalScope":true,"impliedNodeFormat":1},{"version":"54435c7adb578d59d7e39dd2f567250e-const a = class { private p = 10; };","affectsGlobalScope":true,"impliedNodeFormat":1}],"options":{"declaration":true,"declarationMap":true},"emitDiagnosticsPerFile":[[2,[{"pos":6,"end":7,"code":4094,"category":1,"message":"Property 'p' of exported anonymous class type may not be private or protected.","relatedInformation":[{"pos":6,"end":7,"code":9027,"category":1,"message":"Add a type annotation to the variable a."}]}]]],"affectedFilesPendingEmit":[[2,49]]}
 //// [/home/src/projects/project/tsconfig.tsbuildinfo.readable.baseline.txt] *modified* 
 {
   "version": "FakeTSVersion",
@@ -286,6 +298,29 @@ Output::
     "declaration": true,
     "declarationMap": true
   },
+  "emitDiagnosticsPerFile": [
+    [
+      "./a.ts",
+      [
+        {
+          "pos": 6,
+          "end": 7,
+          "code": 4094,
+          "category": 1,
+          "message": "Property 'p' of exported anonymous class type may not be private or protected.",
+          "relatedInformation": [
+            {
+              "pos": 6,
+              "end": 7,
+              "code": 9027,
+              "category": 1,
+              "message": "Add a type annotation to the variable a."
+            }
+          ]
+        }
+      ]
+    ]
+  ],
   "affectedFilesPendingEmit": [
     [
       "./a.ts",
@@ -296,31 +331,14 @@ Output::
       ]
     ]
   ],
-  "size": 1077
+  "size": 1363
 }
 
 tsconfig.json::
 SemanticDiagnostics::
 Signatures::
 
 
-Diff:: !!! Unexpected diff, please review and either fix or write explanation as expectedDiff !!!
---- nonIncremental.output.txt
-+++ incremental.output.txt
-@@ -1,12 +0,0 @@
--a.ts:1:7 - error TS4094: Property 'p' of exported anonymous class type may not be private or protected.
--
--1 const a = class { private p = 10; };
--        ~
--
--  a.ts:1:7 - Add a type annotation to the variable a.
--    1 const a = class { private p = 10; };
--            ~
--
--
--Found 1 error in a.ts:1
--
-
 Edit [3]:: no change
 
 tsgo -b -v --noEmit
@@ -342,7 +360,7 @@ Output::
 [HH:MM:SS AM] Projects in this build: 
     * tsconfig.json
 
-[[90mHH:MM:SS AM[0m] Project 'tsconfig.json' is out of date because buildinfo file 'tsconfig.tsbuildinfo' indicates that some of the changes were not emitted
+[[90mHH:MM:SS AM[0m] Project 'tsconfig.json' is out of date because buildinfo file 'tsconfig.tsbuildinfo' indicates that program needs to report errors.
 
 [HH:MM:SS AM] Building project 'tsconfig.json'...