Report project reference diagnostics (#1515)

Co-authored-by: Copilot <[email protected]>

Author: sheetalkamat

internal/compiler/emitHost.go

@@ -108,8 +108,7 @@ func (host *emitHost) UseCaseSensitiveFileNames() bool {
 }
 
 func (host *emitHost) IsEmitBlocked(file string) bool {
-	// !!!
-	return false
+	return host.program.IsEmitBlocked(file)
 }
 
 func (host *emitHost) WriteFile(fileName string, text string, writeByteOrderMark bool) error {

internal/compiler/program.go

@@ -128,7 +128,7 @@ func (p *Program) GetParseFileRedirect(fileName string) string {
 }
 
 func (p *Program) ForEachResolvedProjectReference(
-	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine),
+	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int),
 ) {
 	p.projectReferenceFileMapper.forEachResolvedProjectReference(fn)
 }
@@ -544,9 +544,7 @@ func (p *Program) verifyCompilerOptions() {
 		}
 	}
 
-	// !!! Option_incremental_can_only_be_specified_using_tsconfig_emitting_to_single_file_or_when_option_tsBuildInfoFile_is_specified
-
-	// !!! verifyProjectReferences
+	p.verifyProjectReferences()
 
 	if options.Composite.IsTrue() {
 		var rootPaths collections.Set[tspath.Path]
@@ -810,12 +808,13 @@ func (p *Program) verifyCompilerOptions() {
 		}
 
 		outputpaths.ForEachEmittedFile(p, options, func(emitFileNames *outputpaths.OutputPaths, sourceFile *ast.SourceFile) bool {
-			if !options.EmitDeclarationOnly.IsTrue() {
-				verifyEmitFilePath(emitFileNames.JsFilePath())
-			}
+			verifyEmitFilePath(emitFileNames.JsFilePath())
+			verifyEmitFilePath(emitFileNames.SourceMapFilePath())
 			verifyEmitFilePath(emitFileNames.DeclarationFilePath())
+			verifyEmitFilePath(emitFileNames.DeclarationMapPath())
 			return false
 		}, p.getSourceFilesToEmit(nil, false), false)
+		verifyEmitFilePath(p.opts.Config.GetBuildInfoFileName())
 	}
 }
 
@@ -824,6 +823,58 @@ func (p *Program) blockEmittingOfFile(emitFileName string, diag *ast.Diagnostic)
 	p.programDiagnostics = append(p.programDiagnostics, diag)
 }
 
+func (p *Program) IsEmitBlocked(emitFileName string) bool {
+	return p.hasEmitBlockingDiagnostics.Has(p.toPath(emitFileName))
+}
+
+func (p *Program) verifyProjectReferences() {
+	buildInfoFileName := core.IfElse(!p.Options().SuppressOutputPathCheck.IsTrue(), p.opts.Config.GetBuildInfoFileName(), "")
+	createDiagnosticForReference := func(config *tsoptions.ParsedCommandLine, index int, message *diagnostics.Message, args ...any) {
+		var sourceFile *ast.SourceFile
+		if config.ConfigFile != nil {
+			sourceFile = config.ConfigFile.SourceFile
+		}
+		diag := tsoptions.ForEachTsConfigPropArray(sourceFile, "references", func(property *ast.PropertyAssignment) *ast.Diagnostic {
+			if ast.IsArrayLiteralExpression(property.Initializer) {
+				value := property.Initializer.AsArrayLiteralExpression().Elements.Nodes
+				if len(value) > index {
+					return tsoptions.CreateDiagnosticForNodeInSourceFileOrCompilerDiagnostic(sourceFile, value[index], message, args...)
+				}
+			}
+			return nil
+		})
+		if diag == nil {
+			diag = ast.NewCompilerDiagnostic(message, args...)
+		}
+		p.programDiagnostics = append(p.programDiagnostics, diag)
+	}
+
+	p.ForEachResolvedProjectReference(func(path tspath.Path, config *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int) {
+		ref := parent.ProjectReferences()[index]
+		// !!! Deprecated in 5.0 and removed since 5.5
+		// verifyRemovedProjectReference(ref, parent, index);
+		if config == nil {
+			createDiagnosticForReference(parent, index, diagnostics.File_0_not_found, ref.Path)
+			return
+		}
+		refOptions := config.CompilerOptions()
+		if !refOptions.Composite.IsTrue() || refOptions.NoEmit.IsTrue() {
+			if len(config.FileNames()) > 0 {
+				if !refOptions.Composite.IsTrue() {
+					createDiagnosticForReference(parent, index, diagnostics.Referenced_project_0_must_have_setting_composite_Colon_true, ref.Path)
+				}
+				if refOptions.NoEmit.IsTrue() {
+					createDiagnosticForReference(parent, index, diagnostics.Referenced_project_0_may_not_disable_emit, ref.Path)
+				}
+			}
+		}
+		if buildInfoFileName != "" && buildInfoFileName == config.GetBuildInfoFileName() {
+			createDiagnosticForReference(parent, index, diagnostics.Cannot_write_file_0_because_it_will_overwrite_tsbuildinfo_file_generated_by_referenced_project_1, buildInfoFileName, ref.Path)
+			p.hasEmitBlockingDiagnostics.Add(p.toPath(buildInfoFileName))
+		}
+	})
+}
+
 func hasZeroOrOneAsteriskCharacter(str string) bool {
 	seenAsterisk := false
 	for _, ch := range str {

internal/compiler/projectreferencefilemapper.go

@@ -140,23 +140,30 @@ func (mapper *projectReferenceFileMapper) getResolvedReferenceFor(path tspath.Pa
 }
 
 func (mapper *projectReferenceFileMapper) forEachResolvedProjectReference(
-	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine),
+	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int),
 ) {
 	if mapper.opts.Config.ConfigFile == nil {
 		return
 	}
+	seenRef := collections.NewSetWithSizeHint[tspath.Path](len(mapper.referencesInConfigFile))
+	seenRef.Add(mapper.opts.Config.ConfigFile.SourceFile.Path())
 	refs := mapper.referencesInConfigFile[mapper.opts.Config.ConfigFile.SourceFile.Path()]
-	mapper.forEachResolvedReferenceWorker(refs, fn)
+	mapper.forEachResolvedReferenceWorker(refs, fn, mapper.opts.Config, seenRef)
 }
 
 func (mapper *projectReferenceFileMapper) forEachResolvedReferenceWorker(
 	references []tspath.Path,
-	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine),
+	fn func(path tspath.Path, config *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int),
+	parent *tsoptions.ParsedCommandLine,
+	seenRef *collections.Set[tspath.Path],
 ) {
-	for _, path := range references {
+	for index, path := range references {
+		if !seenRef.AddIfAbsent(path) {
+			continue
+		}
 		config, _ := mapper.configToProjectReference[path]
-		fn(path, config)
-		mapper.forEachResolvedReferenceWorker(mapper.referencesInConfigFile[path], fn)
+		fn(path, config, parent, index)
+		mapper.forEachResolvedReferenceWorker(mapper.referencesInConfigFile[path], fn, config, seenRef)
 	}
 }
 

internal/execute/tscprojectreferences_test.go

@@ -9,7 +9,6 @@ import (
 func TestProjectReferences(t *testing.T) {
 	t.Parallel()
 	cases := []tscInput{
-		// !!! sheetal todo verifyCompilerOptions - check for noEmit
 		{
 			subScenario: "when project references composite project with noEmit",
 			files: FileMap{
@@ -76,7 +75,6 @@ func TestProjectReferences(t *testing.T) {
 			commandLineArgs: []string{"--p", "project"},
 		},
 		{
-			// !!! sheetal verifyProjectReferences - checks this
 			subScenario: "when project contains invalid project reference",
 			files: FileMap{
 				"/home/src/workspaces/solution/project/index.ts": `export const x = 10;`,

internal/incremental/incremental.go

@@ -3,9 +3,7 @@ package incremental
 import (
 	"github.com/go-json-experiment/json"
 	"github.com/microsoft/typescript-go/internal/compiler"
-	"github.com/microsoft/typescript-go/internal/outputpaths"
 	"github.com/microsoft/typescript-go/internal/tsoptions"
-	"github.com/microsoft/typescript-go/internal/tspath"
 )
 
 type BuildInfoReader interface {
@@ -39,10 +37,7 @@ func NewBuildInfoReader(
 }
 
 func ReadBuildInfoProgram(config *tsoptions.ParsedCommandLine, reader BuildInfoReader) *Program {
-	buildInfoFileName := outputpaths.GetBuildInfoFileName(config.CompilerOptions(), tspath.ComparePathsOptions{
-		CurrentDirectory:          config.GetCurrentDirectory(),
-		UseCaseSensitiveFileNames: config.UseCaseSensitiveFileNames(),
-	})
+	buildInfoFileName := config.GetBuildInfoFileName()
 	if buildInfoFileName == "" {
 		return nil
 	}

internal/incremental/program.go

@@ -240,7 +240,7 @@ func (p *Program) emitBuildInfo(ctx context.Context, options compiler.EmitOption
 		CurrentDirectory:          p.program.GetCurrentDirectory(),
 		UseCaseSensitiveFileNames: p.program.UseCaseSensitiveFileNames(),
 	})
-	if buildInfoFileName == "" {
+	if buildInfoFileName == "" || p.program.IsEmitBlocked(buildInfoFileName) {
 		return nil
 	}
 	if p.snapshot.hasErrors == core.TSUnknown {

internal/project/project.go

@@ -533,7 +533,7 @@ func (p *Project) updateGraph() (*compiler.Program, bool) {
 				}
 			}
 
-			oldProgram.ForEachResolvedProjectReference(func(path tspath.Path, ref *tsoptions.ParsedCommandLine) {
+			oldProgram.ForEachResolvedProjectReference(func(path tspath.Path, ref *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int) {
 				if _, ok := p.program.GetResolvedProjectReferenceFor(path); !ok {
 					p.host.ConfigFileRegistry().releaseConfig(path, p)
 				}
@@ -1096,7 +1096,7 @@ func (p *Project) Close() {
 			// Detach script info if its not root or is root of non inferred project
 			p.detachScriptInfoIfNotInferredRoot(sourceFile.Path())
 		}
-		p.program.ForEachResolvedProjectReference(func(path tspath.Path, ref *tsoptions.ParsedCommandLine) {
+		p.program.ForEachResolvedProjectReference(func(path tspath.Path, ref *tsoptions.ParsedCommandLine, parent *tsoptions.ParsedCommandLine, index int) {
 			p.host.ConfigFileRegistry().releaseConfig(path, p)
 		})
 		if p.kind == KindConfigured {

internal/tsoptions/parsedcommandline.go

@@ -179,6 +179,10 @@ func (p *ParsedCommandLine) CompilerOptions() *core.CompilerOptions {
 	return p.ParsedConfig.CompilerOptions
 }
 
+func (p *ParsedCommandLine) GetBuildInfoFileName() string {
+	return outputpaths.GetBuildInfoFileName(p.CompilerOptions(), p.comparePathsOptions)
+}
+
 func (p *ParsedCommandLine) SetTypeAcquisition(o *core.TypeAcquisition) {
 	p.ParsedConfig.TypeAcquisition = o
 }

testdata/baselines/reference/compiler/superCallInJSWithWrongBaseTypeArgumentCount1(strict=false).js

@@ -31,29 +31,6 @@ exports.A = void 0;
 class A {
 }
 exports.A = A;
-//// [b.js]
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.B3 = exports.B2 = exports.B1 = void 0;
-const a_js_1 = require("./a.js");
-class B1 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B1 = B1;
-class B2 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B2 = B2;
-class B3 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B3 = B3;
 
 
 //// [a.d.ts]

testdata/baselines/reference/compiler/superCallInJSWithWrongBaseTypeArgumentCount1(strict=true).js

@@ -31,29 +31,6 @@ exports.A = void 0;
 class A {
 }
 exports.A = A;
-//// [b.js]
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.B3 = exports.B2 = exports.B1 = void 0;
-const a_js_1 = require("./a.js");
-class B1 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B1 = B1;
-class B2 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B2 = B2;
-class B3 extends a_js_1.A {
-    constructor() {
-        super();
-    }
-}
-exports.B3 = B3;
 
 
 //// [a.d.ts]