Skip to content

[Bug]: http-client-java generator CodeNamer.getEnumMemberName doesn't handle "$100 Gift Card" as an enum #7446

@er1c

Description

@er1c

Describe the bug

Yes; it's a very very bad open api spec that has "$100 Gift Card" as an enum.

CodeNamer.getEnumMemberName("$100 Gift Card") generates: 100_GIFT_CARD which is an invalid java enum as it starts with a digit.

Reproduction

Assertions.assertFalse("100_GIFT_CARD".equals(CodeNamer.getEnumMemberName("$100 Gift Card")));

Will generate:

.... com.microsoft.typespec.http.client.generator.core.util.CodeNamerTests

org.opentest4j.AssertionFailedError: 
Expected :false
Actual   :true

Checklist

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingemitter:client:javaIssue for the Java client emitter: @typespec/http-client-java

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions