Skip to content

Commit 788729e

Browse files
committed
fix: worker processes breaking sessions when attaching multiple times
Fixes microsoft/vscode#124045
1 parent e25ee75 commit 788729e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
1515
- fix: intermittent debug failures with browsers, especially Electron ([ref](https://github.com/microsoft/vscode/issues/123420)))
1616
- fix: add additional languages for browser debugging ([ref](https://github.com/microsoft/vscode/issues/123484))
1717
- feat: allow limited adjustment of launch config options during restart ([ref](https://github.com/microsoft/vscode/issues/118196))
18+
- fix: worker processes breaking sessions when attaching multiple times ([ref](https://github.com/microsoft/vscode/issues/124045))
1819

1920
## v1.56 (April 2021)
2021

src/targets/node/nodeLauncherBase.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ export abstract class NodeLauncherBase<T extends AnyNodeConfiguration> implement
421421
attached: true,
422422
canAccessOpener: false,
423423
type: 'node-worker',
424-
targetId: evt.sessionId,
424+
targetId: `${parent.id()}-${evt.sessionId}`,
425425
title: evt.workerInfo.title,
426426
url: evt.workerInfo.url,
427427
openerId: parent.id(),

0 commit comments

Comments
 (0)