Skip to content

Commit d0cccb4

Browse files
Copiloteleanorjboyd
andcommitted
Add modal dialog support for invalid interpreter errors
- Modified DiagnosticCommandPromptHandlerService to display error severity diagnostics as modal dialogs - Updated all related unit tests to expect modal option for error messages - This makes invalid interpreter errors more prominent and blocking as requested Co-authored-by: eleanorjboyd <[email protected]>
1 parent d02f700 commit d0cccb4

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

src/client/application/diagnostics/promptHandler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class DiagnosticCommandPromptHandlerService implements IDiagnosticHandler
5454
): Promise<string | undefined> {
5555
switch (severity) {
5656
case DiagnosticSeverity.Error: {
57-
return this.appShell.showErrorMessage(message, ...prompts);
57+
return this.appShell.showErrorMessage(message, { modal: true }, ...prompts);
5858
}
5959
case DiagnosticSeverity.Warning: {
6060
return this.appShell.showWarningMessage(message, ...prompts);

src/test/application/diagnostics/promptHandler.unit.test.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,12 @@ suite('Application Diagnostics - PromptHandler', () => {
4747
switch (severity.value) {
4848
case DiagnosticSeverity.Error: {
4949
appShell
50-
.setup((a) => a.showErrorMessage(typemoq.It.isValue(diagnostic.message)))
50+
.setup((a) =>
51+
a.showErrorMessage(
52+
typemoq.It.isValue(diagnostic.message),
53+
typemoq.It.isValue({ modal: true }),
54+
),
55+
)
5156
.verifiable(typemoq.Times.once());
5257
break;
5358
}
@@ -92,6 +97,7 @@ suite('Application Diagnostics - PromptHandler', () => {
9297
.setup((a) =>
9398
a.showErrorMessage(
9499
typemoq.It.isValue(options.message!),
100+
typemoq.It.isValue({ modal: true }),
95101
typemoq.It.isValue('Yes'),
96102
typemoq.It.isValue('No'),
97103
),
@@ -152,6 +158,7 @@ suite('Application Diagnostics - PromptHandler', () => {
152158
.setup((a) =>
153159
a.showErrorMessage(
154160
typemoq.It.isValue(options.message!),
161+
typemoq.It.isValue({ modal: true }),
155162
typemoq.It.isValue('Yes'),
156163
typemoq.It.isValue('No'),
157164
),
@@ -213,6 +220,7 @@ suite('Application Diagnostics - PromptHandler', () => {
213220
.setup((a) =>
214221
a.showErrorMessage(
215222
typemoq.It.isValue(options.message!),
223+
typemoq.It.isValue({ modal: true }),
216224
typemoq.It.isValue('Yes'),
217225
typemoq.It.isValue('No'),
218226
),

0 commit comments

Comments
 (0)