Fixing async apis and reducing the number of threads we block #15289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
commented
Oct 3, 2025
| // todo: report standard error on timeout | ||
| await Task.WhenAny(_communicationManager.AcceptClientAsync(), Task.Delay(clientConnectionTimeout)).ConfigureAwait(false); | ||
|
|
||
| _handShakeSuccessful = await HandShakeWithVsTestConsoleAsync().ConfigureAwait(false); |
There was a problem hiding this comment.
This code is completely broken. We are waiting for console to connect here, but we did not return from this method, so the port was never given to the code that starts the console. So there is no process that would ever call us back.
nohwnd
commented
Oct 3, 2025
Comment on lines
+6
to
+7
| "DOTNET_ThreadPool_ForceMinWorkerThreads": "1", | ||
| "DOTNET_ThreadPool_ForceMaxWorkerThreads": "1" |
There was a problem hiding this comment.
forces us to single threadpool thread to make sure we don't get blocked when running, and don't block threadpool threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. if we do discoveryAsync, and then do RunTests (sync), we get stuck.