Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package Issue]: "Bitwarden.Bitwarden" fails to update unless you manually close the app. #224299

Open
2 tasks done
richardhttps opened this issue Feb 7, 2025 · 4 comments
Open
2 tasks done
Labels
Area-External Installer-Issue Issue with the package's installer. Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@richardhttps
Copy link

richardhttps commented Feb 7, 2025

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Installation issue.

Brief description of your issue

Update fails with a Bittwarden installer prompt showing the following error:

Failed to uninstall old application files. Please try running the installer again.:2

winget update is initiated with these arguments:
update --id "Bitwarden.Bitwarden" --exact --source winget --accept-source-agreements --disable-interactivity --silent --include-unknown --accept-package-agreements --force

Steps to reproduce

Use winget to update Bitwarden while Bitwarden is open in the background, using the following arguments:
update --id "Bitwarden.Bitwarden" --exact --source winget --accept-source-agreements --disable-interactivity --silent --include-unknown --accept-package-agreements --force

Actual behavior

Update fails with a Bitwarden installer prompt that shows the following error:

Failed to uninstall old application files. Please try running the installer again.:2

Expected behavior

Update in the background without user interaction.

Environment

Windows Package Manager v1.9.25200
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26100.3037
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.25200.0

Screenshots and Logs

No response

@richardhttps richardhttps added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Feb 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Feb 7, 2025
@Dragon1573
Copy link
Contributor

Dragon1573 commented Feb 7, 2025

I think "automatically close the application before upgrading" should be done by the install wizard itself.

I'm currently using package AList.AList as a local web server and I register it as a Windows Service using package NSSM.NSSM. When I upgrade AList via WinGet, I HAVE TO manually stop the service in advanced, otherwise the upgrade will fail.

@Trenly
Copy link
Contributor

Trenly commented Feb 7, 2025

It is an intentional design choice of WinGet to not close running applications before upgrade so that WinGet does not cause the loss of data from terminating an application in an un-saved state. If the installer provides a specific return code that the files are in use, we can add that to the manifest, but @Dragon1573 is correct, any automatic closing of the application must be done by the installer of the application.

[Policy] Area External; [Policy] Installer Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Area-External Installer-Issue Issue with the package's installer. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Feb 7, 2025
@Dragon1573
Copy link
Contributor

If the installer provides a specific return code that the files are in use, we can add that to the manifest.

What behavior is it at the moment? Will winget.exe just notify users for saving data and quit the application themselves? Or it will prompt for a request, save and terminate automatically after users' approval?

@Trenly
Copy link
Contributor

Trenly commented Feb 7, 2025

If the installer provides a specific return code that the files are in use, we can add that to the manifest.

What behavior is it at the moment? Will winget.exe just notify users for saving data and quit the application themselves? Or it will prompt for a request, save and terminate automatically after users' approval?

Neither. It just provides a better message as to why the install failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-External Installer-Issue Issue with the package's installer. Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants