Merge pull request #101 from microsoftgraph/dev

Sync up master with changes in dev

Author: muthurathinam

.gitignore

@@ -1,10 +1,13 @@
-.vscode/
+/.vscode/*
+!/.vscode/launch.json
 .DS_Store
 .tmp
 tmp
 node_modules
 typings
 src/**/*.js
+src/**/*.js.map
+src/**/*.d.ts
 coverage
 **/*.tgz
 samples/node/secrets.json
@@ -16,7 +19,6 @@ samples/typescript/graph-typings.d.ts
 samples/typescript/sample.js.map
 src/index.d.ts
 
-spec/types/secrets*
-spec/types/*.js
-spec/types/*.d.ts
-spec/types/*.js.map
+spec/**/*.js
+spec/**/*.d.ts
+spec/**/*.js.map

.jshintrc

@@ -0,0 +1,3 @@
+{
+  "esnext": "true"
+}

.vscode/launch.json

@@ -0,0 +1,29 @@
+{
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "Run node samples",
+            "program": "${workspaceRoot}/samples/node/node-sample.js",
+            "cwd": "${workspaceRoot}",
+            "outFiles": [],
+            "internalConsoleOptions": "openOnSessionStart"
+        },
+        {
+            "type": "node",
+            "request": "launch",
+            "name": "Run core tests",
+            "program": "${workspaceRoot}/node_modules/mocha/bin/_mocha",
+            "args": [
+                "${workspaceRoot}/lib/spec/core/*.js"
+            ],
+            "cwd": "${workspaceRoot}",
+            "outFiles": [],
+            "internalConsoleOptions": "openOnSessionStart"
+        }
+    ]
+}

CHANGELOG.md

@@ -0,0 +1,46 @@
+## Changelog
+
+### 1.2.0
+Updates
+
+* Two output js files, one with polyfills for Fetch-API and ES6-Promises ([lib/graph-js-sdk-web.js](./lib/graph-js-sdk-web.js)) and one without ([lib/graph-js-sdk-core.js](./lib/graph-js-sdk-core.js))
+[Refer [README.md](https://github.com/microsoftgraph/msgraph-sdk-javascript#browser) for usage]
+* Enum for ResponseType, which lists down the available ResponseType options in autocomplete
+
+Bug Fix
+* Cannot access the property "request-id" of undefined in GraphError handling
+
+### 1.1.0
+New Features
+* Support for Multipart POST request
+
+Updates
+* Light weight FetchAPI dependency (in replacement for SuperAgent)
+
+Bug Fixes
+* Updated putStream and getStream to work for all sized files
+* Added obfuscation for output js file (graph-js-sdk-web.js)
+* Updated versions of mocha and chai to 5.2.0 and 4.1.2 to fix security vulnerability in growl (which is a dependency of mocha)
+* Running unit test files under types directory
+* Compiling ts files
+
+#### 1.0.0
+* Added tests for new Graph functionality - Delta query, Extensibility, OneNote, and more.
+
+#### 0.4.0
+* Add support for ES5. Make sure to use `graph-js-sdk-web.js` for web apps
+* Removed iterator helper method.
+
+#### 0.3.1
+* Support for Node.js versions 4 and 5
+
+#### 0.3.0
+* Migrated away from typings in client library core and TypeScript sample
+
+#### 0.2.2
+* Updated SuperAgent to version ``` 3.3.0 ```
+
+#### 0.2.0
+* **Breaking change for existing apps** - Initialize the client library with `MicrosoftGraph.Client.init({...})`. See the updated usage section below for code samples.
+* Added response handling tests to simulate Graph calls
+* Added type declarations file for core client library, which adds intellisense for chained methods.

README.md

@@ -18,7 +18,14 @@ The Microsoft Graph JavaScript client library is a lightweight wrapper around th
 
 ### Browser
 
-Include [lib/graph-js-sdk-web.js](https://github.com/microsoftgraph/msgraph-sdk-javascript/raw/master/lib/graph-js-sdk-web.js) in your page.
+The library comes with two varieties of options, you can pick one based on your use case
+
+1. If your application has polyfills for **Fetch-API** and **ES6-Promise**, then can just include [lib/graph-js-sdk-core.js](./lib/graph-js-sdk-core.js) in your page.
+```html
+<script type="text/javascript" src="graph-js-sdk-core.js"></script>
+```
+
+2. If your application does not have polyfills for **Fetch-API** and **ES6-Promise**, then you have to include [lib/graph-js-sdk-web.js](./lib/graph-js-sdk-web.js) in your page.
 ```html
 <script type="text/javascript" src="graph-js-sdk-web.js"></script>
 ```
@@ -151,7 +158,7 @@ let fs = require('fs'); // requires filesystem module
 let stream = fs.createReadStream('./logo.png'); //path to local file
 client
     .api('/me/drive/root/children/logo.png/content') // path to the destination in OneDrive
-    .put(stream, (err) => {
+    .putStream(stream, (err) => {
         console.log(err);
     });
 ````
@@ -241,7 +248,29 @@ You can pass in additional request headers, either individually or in a dictiona
 ````
 
 ### .responseType()
-To set a custom response type, use the `.responseType(string)` method.  To see an example, check the [browser sample](samples/browser/index.html) that downloads an image and displays it in an `<img>` element.
+To set a custom response type, use the `.responseType(<ResponseType>)` method. Refer [ResponseType.ts](./src/ResponseType.ts) for available options.
+````js
+client
+    .api(`/me/drive/root/children/${fileName}/content`)
+    .responseType(MicrosoftGraph.ResponseType.BLOB)
+    .get()
+    .then((res) => {
+        console.log("Downloaded..!!");
+    })
+    .catch((err) => {
+        throw err;
+    });
+````
+
+## Running node samples
+You can run and debug the node samples found under [./samples/node/node-sample.js](./samples/node/node-sample.js) by running the *Run node samples* configuration from the **Debug** (Ctrl + Shift + D) menu in Visual Studio Code. Alternately, you can run the node samples from the CLI by entering `node ./samples/node/node-sample.js` (assuming you are at the root of this repo). You'll need to rename the *secrets.example.json* file to *secrets.json* and add a valid access token to it. You can get an access token by doing the following:
+1. Go to [Graph Explorer](https://developer.microsoft.com/en-us/graph/graph-explorer).
+2. Login with the account you want to use to run the node samples.
+3. Open the F12 dev tools.
+4. Type `tokenPlease()` into the console to get an access token.
+5. Copy the access token and put it into the *secrets.json* file and save the file.
+
+We suggest that you become acquainted with these samples as they show some of the main use scenarios for this client library.
 
 ## Additional information
 ### Options in `MicrosoftGraph.Client.init()`
@@ -287,7 +316,7 @@ These steps are not required to use this library.
 
 ```npm pack``` bundles the npm module.
 
-```npm test``` runs tests of the core library (URL parsing, mock responses, etc)
+```npm test``` runs tests of the core library (URL parsing, mock responses, etc). You can also set breakpoints and run this from within Visual Studio Code by selecting the *Run core test* configuration from the Debug view.
 
 ```npm run test:types``` to run tests against the Graph API for users, groups, Excel, OneNote, etc.
 
@@ -303,28 +332,6 @@ We'd love to get your feedback about the Microsoft Graph JavaScript client libra
 
 ## Contributing
 Please see the [contributing guidelines](CONTRIBUTING.md).
-## Changelog
-
-#### 1.0.0
-* Added tests for new Graph functionality - Delta query, Extensibility, OneNote, and more.
-
-#### 0.4.0
-* Add support for ES5. Make sure to use `graph-js-sdk-web.js` for web apps
-* Removed iterator helper method.
-
-#### 0.3.1
-* Support for Node.js versions 4 and 5
-
-#### 0.3.0
-* Migrated away from typings in client library core and TypeScript sample
-
-#### 0.2.2
-* Updated SuperAgent to version ``` 3.3.0 ```
-
-#### 0.2.0
-* **Breaking change for existing apps** - Initialize the client library with `MicrosoftGraph.Client.init({...})`. See the updated usage section below for code samples.
-* Added response handling tests to simulate Graph calls
-* Added type declarations file for core client library, which adds intellisense for chained methods.
 
 
 ## Additional resources
@@ -339,3 +346,6 @@ Please see the [contributing guidelines](CONTRIBUTING.md).
 Copyright (c) Microsoft Corporation. All rights reserved.
 
 This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected]) with any additional questions or comments.
+
+## Third Party Notices
+See [Third Party Notices](https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/master/THIRD%20PARTY%20NOTICES) for information on the packages that are included in the [package.json](https://github.com/microsoftgraph/msgraph-sdk-javascript/blob/master/package.json)

THIRD PARTY NOTICES

@@ -0,0 +1,17 @@
+This file is based on or incorporates material from the projects listed below (Third Party OSS). The original copyright notice and the license under which Microsoft received such Third Party OSS, are set forth below. Such licenses and notices are provided for informational purposes only. Microsoft licenses the Third Party OSS to you under the licensing terms for the Microsoft product or service. Microsoft 
+reserves all other rights not expressly granted under this agreement, whether by implication, estoppel or otherwise.  
+
+superagent - 3.5.2
+
+es6-promise - 4.1.0
+ 
+Provided for Informational Purposes Only 
+  
+MIT License  
+ 
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the Software), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:  
+ 
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. 
+ 
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF  
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. 

browser-wrapper.js

@@ -1,3 +1,3 @@
 // make MicrosoftGraph globally accessible
 // MicrosoftGraph.api() can be called directly
-window.MicrosoftGraph = require('./lib/src/index.js');
+window.MicrosoftGraph = require('./lib/src/index.js');

core-browserify.js

@@ -0,0 +1,6 @@
+var browserify = require('browserify');
+var b = browserify();
+b.add('./browser-wrapper.js');
+b.external("es6-promise");
+b.external("isomorphic-fetch");
+b.bundle().pipe(process.stdout);