Duplicate lines of code in Connection.js #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

babakness opened this issue Feb 8, 2017 · 1 comment

babakness commented Feb 8, 2017 •

edited

Loading

When looking around this code I noticed a duplicate

https://github.com/mikemintz/rethinkdb-websocket-server/blob/master/src/Connection.js#L29
https://github.com/mikemintz/rethinkdb-websocket-server/blob/master/src/Connection.js#L45

Perhaps I'm missing something here?

babakness changed the title ~~Seemingly redundant code~~ Duplicate lines of code in Connection.js

Owner

mikemintz commented Feb 9, 2017

Good catch! Feel free to open a PR removing the second line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment