Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobclient init fails with gnumake 4.4 and make --jobserver-style=fifo #5

Closed
milahu opened this issue Dec 24, 2023 · 4 comments
Closed

Comments

@milahu
Copy link
Owner

milahu commented Dec 24, 2023

currently, the jobclient fails to parse MAKEFLAGS like -j2 --jobserver-auth=fifo:/tmp/asdf

$ ./py/test/test.sh 
+ make -j2
python3 test.py "jobserver on"
debug jobclient.py 781944 2023-12-24 11:01:16.407: init: MAKEFLAGS:  -j2 --jobserver-auth=fifo:/tmp/GMfifo781943
debug jobclient.py 781944 2023-12-24 11:01:16.410: init: fdRead = None, fdWrite = None, maxJobs = 2, maxLoad = None
debug jobclient.py 781944 2023-12-24 11:01:16.410: init failed: no fds

make --jobserver-style=fifo is the default since gnumake 4.4

quickfix: make --jobserver-style=pipe

gnumake docs

--jobserver-style=[style]

Chooses the style of jobserver to use. This option only has effect if parallel builds are enabled (see Parallel Execution). On POSIX systems style can be one of fifo (the default) or pipe. On Windows the only acceptable style is sem (the default). This option is useful if you need to use an older versions of GNU make, or a different tool that requires a specific jobserver style.

see also

@milahu
Copy link
Owner Author

milahu commented Dec 24, 2023

jobserver-style fifo should work now in javascript and python

@mkoeppe feel free to make a new python release

@mkoeppe
Copy link
Collaborator

mkoeppe commented Dec 25, 2023

Great. I'll set up a GH Actions workflow that will publish to PyPI when a py/... tag is pushed

@mkoeppe
Copy link
Collaborator

mkoeppe commented Dec 25, 2023

https://pypi.org/project/gnumake-tokenpool/0.0.6/ (created by the new GH Actions workflow)

@milahu
Copy link
Owner Author

milahu commented Mar 4, 2024

closing as "should be fixed"

jobserver-style fifo should work now in javascript and python

@milahu milahu closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants