Shader Crash on 1.4.3

[Apollonu]

CTR VCR version

1.4.3

Minecraft version

1.20.1

Mod Loader

Forge

Shader Loader

Oculus

Graphics card

RX 580

Issue description

I am able to use 1.3.1, but 1.4.3 does not work at all and makes my hand invisible
net.minecraft.server.ChainedJsonException: Invalid shaders/core/textured.json: The call m_166612_ is not cancellable.

Issue reproduction

Use 1.4.3 with oculus and see the issue.

Logs

debug.log
latest.log

[millennIumAMbiguity]

hopefully its a Oculus issue and not GPU issue. If you have time, can you check if it works on iris?

[millennIumAMbiguity]

I believe the solution is to remove any alpha check for hand texture render

[Apollonu]

hopefully its a Oculus issue and not GPU issue. If you have time, can you check if it works on iris?

This is what happened when I tested on iris, as a note im using Java 26. My gpu is an RX 580 if it comes to it though.
textured.fsh: textured.fsh: 0:89(25): error: `return' with wrong type int, in function `Fog' returning float

latest.log

[millennIumAMbiguity]

Does using the latest commit fix the issue?

[Apollonu]

Does using the latest commit fix the issue?

Yes that fixes my issue, but im now running into another one. With stellar view for some reason I am now running into visual artifacts, and none of the config options change anything. It works fine on 1.3.1 not perfect but that doesn't matter its usable, its very bright as seen below on the latest version. Is it possible to fix this or add support for resourcepack skies?
1.3.1:

Latest commit:

[millennIumAMbiguity]

I made it so that stars would not get affected by fog.
You can disable it by removing line 27 from program/gbuffers_basic.fsh

if it causing issues with mods, then its not worth it.

[Apollonu]

I made it so that stars would not get affected by fog. You can disable it by removing line 27 from program/gbuffers_basic.fsh

if it causing issues with mods, then its not worth it.

Commenting out line 27 turned it into this, and as a note stellar view should be acting like a resourcepack with its static sky config on (which is what needs to be enabled for it to work with shaders) if it helps you understand whats happening.

On 1.3.1 again for refrence on what it should look like:

I could try and find which version this first occurs after 1.3.1, but im unsure if it would help

[millennIumAMbiguity]

It would help.

[Apollonu]

It would help.

1.4.1 Is where it is introduced.