diff --git a/src/impl/MilvusClientImpl.cpp b/src/impl/MilvusClientImpl.cpp index db66182c..e1cd3419 100644 --- a/src/impl/MilvusClientImpl.cpp +++ b/src/impl/MilvusClientImpl.cpp @@ -888,7 +888,7 @@ MilvusClientImpl::CalcDistance(const CalcDistanceArguments& arguments, DistanceA kv->set_key("metric"); kv->set_value(arguments.MetricType()); - return std::move(rpc_request); + return rpc_request; }; auto post = [&arguments, &results](const proto::milvus::CalcDistanceResults& response) { diff --git a/src/impl/MilvusConnection.cpp b/src/impl/MilvusConnection.cpp index 7b66b042..2ef5e68d 100644 --- a/src/impl/MilvusConnection.cpp +++ b/src/impl/MilvusConnection.cpp @@ -45,7 +45,7 @@ createTlsCredentials(const std::string& cert, const std::string& key, const std: std::string buffer(size, '\0'); fs.seekg(0); fs.read(&buffer[0], size); - return std::move(buffer); + return buffer; } return ""; }; diff --git a/src/include/milvus/MilvusClient.h b/src/include/milvus/MilvusClient.h index f515ce6f..8ae65815 100644 --- a/src/include/milvus/MilvusClient.h +++ b/src/include/milvus/MilvusClient.h @@ -52,6 +52,7 @@ namespace milvus { */ class MilvusClient { public: + virtual ~MilvusClient() = default; /** * Create a MilvusClient instance. * diff --git a/src/include/milvus/types/DistanceArray.h b/src/include/milvus/types/DistanceArray.h index 8466b0ab..a7c77a66 100644 --- a/src/include/milvus/types/DistanceArray.h +++ b/src/include/milvus/types/DistanceArray.h @@ -105,9 +105,9 @@ class DistanceArray { SetFloatDistance(std::vector>&& distance_array); private: - bool is_int_distance_{false}; std::vector> int_array_; std::vector> float_array_; + bool is_int_distance_{false}; }; } // namespace milvus diff --git a/src/include/milvus/types/FieldData.h b/src/include/milvus/types/FieldData.h index bf827a3b..0d4eb738 100644 --- a/src/include/milvus/types/FieldData.h +++ b/src/include/milvus/types/FieldData.h @@ -42,6 +42,8 @@ class Field { virtual size_t Count() const = 0; + virtual ~Field() = default; + protected: Field(std::string name, DataType data_type); diff --git a/src/include/milvus/types/IDArray.h b/src/include/milvus/types/IDArray.h index 38429ba0..a4630ac3 100644 --- a/src/include/milvus/types/IDArray.h +++ b/src/include/milvus/types/IDArray.h @@ -67,9 +67,9 @@ class IDArray { StrIDArray() const; private: - bool is_int_array_{true}; std::vector int_id_array_; std::vector str_id_array_; + bool is_int_array_{true}; }; } // namespace milvus diff --git a/src/include/milvus/types/IndexDesc.h b/src/include/milvus/types/IndexDesc.h index 42024691..f7dfa3d8 100644 --- a/src/include/milvus/types/IndexDesc.h +++ b/src/include/milvus/types/IndexDesc.h @@ -138,9 +138,9 @@ class IndexDesc { private: std::string field_name_; std::string index_name_; - int64_t index_id_{0}; - milvus::MetricType metric_type_{milvus::MetricType::INVALID}; milvus::IndexType index_type_{milvus::IndexType::INVALID}; + milvus::MetricType metric_type_{milvus::MetricType::INVALID}; + int64_t index_id_{0}; std::unordered_map extra_params_; };