Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: broadcast with event-based notification #39522

Merged
merged 2 commits into from
Feb 7, 2025

fix: unittest

d75e801
Select commit
Loading
Failed to load commit list.
Refresh
Merged

enhance: broadcast with event-based notification #39522

fix: unittest
d75e801
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 23, 2025 in 1s

86.64% of diff hit (target 80.00%)

View this Pull Request on Codecov

86.64% of diff hit (target 80.00%)

Annotations

Check warning on line 31 in internal/coordinator/coordclient/test_utility.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/coordinator/coordclient/test_utility.go#L30-L31 

Added lines #L30 - L31 were not covered by tests

Check warning on line 82 in internal/streamingcoord/client/broadcast/broadcast_impl.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/broadcast_impl.go#L81-L82 

Added lines #L81 - L82 were not covered by tests

Check warning on line 36 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L34-L36 

Added lines #L34 - L36 were not covered by tests

Check warning on line 74 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L71-L74 

Added lines #L71 - L74 were not covered by tests

Check warning on line 130 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L129-L130 

Added lines #L129 - L130 were not covered by tests

Check warning on line 154 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L153-L154 

Added lines #L153 - L154 were not covered by tests

Check warning on line 184 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L182-L184 

Added lines #L182 - L184 were not covered by tests

Check warning on line 189 in internal/streamingcoord/client/broadcast/grpc_watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/grpc_watcher.go#L188-L189 

Added lines #L188 - L189 were not covered by tests

Check warning on line 47 in internal/streamingcoord/client/broadcast/watcher_resuming.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/watcher_resuming.go#L46-L47 

Added lines #L46 - L47 were not covered by tests

Check warning on line 57 in internal/streamingcoord/client/broadcast/watcher_resuming.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/watcher_resuming.go#L54-L57 

Added lines #L54 - L57 were not covered by tests

Check warning on line 129 in internal/streamingcoord/client/broadcast/watcher_resuming.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/watcher_resuming.go#L127-L129 

Added lines #L127 - L129 were not covered by tests

Check warning on line 163 in internal/streamingcoord/client/broadcast/watcher_resuming.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/client/broadcast/watcher_resuming.go#L162-L163 

Added lines #L162 - L163 were not covered by tests

Check warning on line 34 in internal/streamingcoord/server/broadcaster/broadcast_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/broadcast_manager.go#L34 

Added line #L34 was not covered by tests

Check warning on line 69 in internal/streamingcoord/server/broadcaster/broadcast_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/broadcast_manager.go#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 85 in internal/streamingcoord/server/broadcaster/broadcast_manager.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/broadcast_manager.go#L83-L85 

Added lines #L83 - L85 were not covered by tests

Check warning on line 134 in internal/streamingcoord/server/broadcaster/broadcast_task.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/broadcast_task.go#L134 

Added line #L134 was not covered by tests

Check warning on line 152 in internal/streamingcoord/server/broadcaster/broadcast_task.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/broadcast_task.go#L152 

Added line #L152 was not covered by tests

Check warning on line 46 in internal/streamingcoord/server/broadcaster/watcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/broadcaster/watcher.go#L41-L46 

Added lines #L41 - L46 were not covered by tests

Check warning on line 37 in internal/streamingcoord/server/service/broadcast.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast.go#L37 

Added line #L37 was not covered by tests

Check warning on line 48 in internal/streamingcoord/server/service/broadcast.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast.go#L45-L48 

Added lines #L45 - L48 were not covered by tests

Check warning on line 63 in internal/streamingcoord/server/service/broadcast.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast.go#L52-L63 

Added lines #L52 - L63 were not covered by tests

Check warning on line 70 in internal/streamingcoord/server/service/broadcast.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast.go#L69-L70 

Added lines #L69 - L70 were not covered by tests

Check warning on line 74 in internal/streamingcoord/server/service/broadcast.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast.go#L73-L74 

Added lines #L73 - L74 were not covered by tests

Check warning on line 86 in internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go#L85-L86 

Added lines #L85 - L86 were not covered by tests

Check warning on line 105 in internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/streamingcoord/server/service/broadcast/broadcast_watch_server.go#L104-L105 

Added lines #L104 - L105 were not covered by tests
View more details on Codecov