Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and resolve accessibility issues raised on sortable table component and search component #1110

Open
robertjmccarthy opened this issue Jan 23, 2025 · 5 comments
Assignees

Comments

@robertjmccarthy
Copy link
Contributor

robertjmccarthy commented Jan 23, 2025

What

Document the accessibility issue for the components on the site, resolve the identified issue, implement the update, and notify users accordingly.

Why

Slack message on support channel flagged an accessibility issue raised: https://mojdt.slack.com/archives/CH5RUSB27/p1737129000538939

Who needs to be involved

  • Accessibility Specialist (leading)
  • Developer (supporting)

Done

When a resolution is found, applied and communicated out to users (and specifically communicated to the team that raised the issue)

@helennickols
Copy link
Contributor

@Whersi Hi, could you add the accessibility info from Ben here please so that I can view it? Thanks

@Whersi
Copy link

Whersi commented Jan 27, 2025

@helennickols Accessibility notices for components with known issues

@helennickols helennickols self-assigned this Jan 27, 2025
@helennickols
Copy link
Contributor

@chrispymm Do you know the fix date? It will go into this template:
Image

@robertjmccarthy @jbarnardmoj Is the notification badge built into the template yet? I was proposing we could publish the accessibility statement first and then add the badge. WDYT? Or easier to do it all together? The content is in progress...

@helennickols helennickols removed their assignment Jan 27, 2025
@robertjmccarthy
Copy link
Contributor Author

Accessibility issue information added to component pages for sortable table and search.

To be done

  • Fix found and applied to both components
  • Information to be removed from components once fix applied

@robertjmccarthy robertjmccarthy moved this from In Progress to Blocked in MoJ Design System: Team planning Jan 29, 2025
@Whersi Whersi moved this from Blocked to To Do in MoJ Design System: Team planning Feb 12, 2025
@robertjmccarthy robertjmccarthy moved this from To Do to In Progress in MoJ Design System: Team planning Feb 20, 2025
@robertjmccarthy robertjmccarthy moved this from In Progress to To Do in MoJ Design System: Team planning Feb 20, 2025
@chrispymm
Copy link
Contributor

Update

Sortable Table

  • Sortable table fix is relatively easy, but is likely a breaking change to the component.
  • Given our new component statuses/roadmap we need a team discussion around the priority/timeline for this fix. We may choose to leave it until we officially review and update the component.
  • If we choose to. delay, we will then need to update the guidance site to reflect the new timeline.

Search

  • The close button in question is actually added by the browser as it is an input type="search"
  • @benproctor-rogers to contact uservision to see if this is still a fail (probably)
  • If it is, the fix is a simple one - to switch to an input type="text"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Do
Development

No branches or pull requests

5 participants