Fix SML pak not being downloaded

Author: mircearoata

src/smlHandler.ts

@@ -3,7 +3,7 @@ import fs from 'fs';
 import bindings from 'bindings';
 import { valid, coerce } from 'semver';
 import {
-  downloadFile, fileURLExists,
+  downloadFile,
 } from './utils';
 import { ModNotFoundError } from './errors';
 import { debug } from './logging';
@@ -42,11 +42,14 @@ async function getSMLVersionCache(version: string): Promise<string> {
     }
     const smlDLLDownloadLink = `${smlReleaseURL.replace('/tag/', '/download/')}/${SMLDLLFileName}`;
     const smlPakDownloadLink = `${smlReleaseURL.replace('/tag/', '/download/')}/${SMLPakFileName}`;
-    const hasPak = await fileURLExists(smlPakDownloadLink);
-    await downloadFile(smlDLLDownloadLink, smlDLLVerionCacheFile, `SML ${hasPak ? '(1/2)' : '(1/1)'}`, validVersion);
-    if (hasPak) {
-      await downloadFile(smlPakDownloadLink, smlPakVerionCacheFile, 'SML (2/2)', validVersion);
+    let hasPak = true;
+    try {
+      await downloadFile(smlPakDownloadLink, smlPakVerionCacheFile, 'SML (1/2)', validVersion);
+    } catch (e) {
+      hasPak = false;
+      debug(`Pak of SML version ${version} not found.`);
     }
+    await downloadFile(smlDLLDownloadLink, smlDLLVerionCacheFile, `SML ${hasPak ? '(2/2)' : '(1/1)'}`, validVersion);
   }
   return smlVersionCacheDir;
 }

src/utils.ts

@@ -6,7 +6,7 @@ import { execSync } from 'child_process';
 import got, { HTTPError, Progress } from 'got';
 import { createHash } from 'crypto';
 import {
-  setLogDebug, debug, error,
+  setLogDebug, debug,
 } from './logging';
 import { NetworkError } from './errors';
 import {
@@ -101,25 +101,6 @@ export function addDownloadProgressCallback(cb: ProgressCallback): void {
   }
 }
 
-export async function fileURLExists(url: string): Promise<boolean> {
-  try {
-    const res = await got(url, {
-      method: 'HEAD',
-      dnsCache: false,
-      headers: {
-        'User-Agent': UserAgent,
-      },
-    });
-    return res.statusCode === 200;
-  } catch (e) {
-    if (e instanceof HTTPError) {
-      return false;
-    }
-    error(e);
-    throw new Error(`Error checking if ${url} exists.`);
-  }
-}
-
 export async function downloadFile(url: string, file: string, name: string, version: string): Promise<void> {
   let interval: NodeJS.Timeout | undefined;
   try {