Skip to content

Commit fd6e2a5

Browse files
committed
client: use common -n/--name parameter for xlx and intel commands
This deprecates the -r/--resource parameter used for xlx and intel subcommands in favor of the commonly used -n/--name parameter used by all other subcommands.
1 parent af0ab0b commit fd6e2a5

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

labgrid/remote/client.py

+6-8
Original file line numberDiff line numberDiff line change
@@ -1307,21 +1307,21 @@ def _get_xlx(self, name):
13071307
return drv
13081308

13091309
def xlx_run_xsdb(self):
1310-
drv = self._get_xlx(self.args.resource)
1310+
drv = self._get_xlx(self.args.name)
13111311

13121312
processwrapper.enable_print()
13131313
drv.run([self.args.tcl_cmds])
13141314
processwrapper.disable_print()
13151315

13161316
def xlx_program_bitstream(self):
1317-
drv = self._get_xlx(self.args.resource)
1317+
drv = self._get_xlx(self.args.name)
13181318

13191319
processwrapper.enable_print()
13201320
drv.program_bitstream(self.args.bitstream)
13211321
processwrapper.disable_print()
13221322

13231323
def xlx_force_bootmode(self):
1324-
drv = self._get_xlx(self.args.resource)
1324+
drv = self._get_xlx(self.args.name)
13251325
drv.force_bootmode_reset(self.args.bootmode.lower())
13261326

13271327
def _get_quartus(self, name):
@@ -1344,7 +1344,7 @@ def _get_quartus(self, name):
13441344
return drv
13451345

13461346
def intel_program_bitstream(self):
1347-
drv = self._get_quartus(self.args.resource)
1347+
drv = self._get_quartus(self.args.name)
13481348
processwrapper.enable_print()
13491349
ret, stdout, stderr = drv.flash(self.args.bitstream)
13501350
if not ret:
@@ -1904,6 +1904,7 @@ def main():
19041904
subparser.set_defaults(func=ClientSession.write_image)
19051905

19061906
subparser = subparsers.add_parser('xlx', help="connect to a Xilinx Vivado hardware server")
1907+
subparser.add_argument("--name", "-n", help="optional resource name")
19071908
subparser.set_defaults(func=lambda _: subparser.print_help())
19081909
xlx_subparsers = subparser.add_subparsers(
19091910
dest='subcommand',
@@ -1912,21 +1913,19 @@ def main():
19121913
)
19131914

19141915
xlx_subparser = xlx_subparsers.add_parser('xsdb', help="run XSDB")
1915-
xlx_subparser.add_argument('-r,', '--resource', help="resource name")
19161916
xlx_subparser.add_argument('tcl_cmds', help="Tcl commands")
19171917
xlx_subparser.set_defaults(func=ClientSession.xlx_run_xsdb)
19181918

19191919
xlx_subparser = xlx_subparsers.add_parser('program-bitstream', help="program bitstream")
1920-
xlx_subparser.add_argument('-r,', '--resource', help="resource name")
19211920
xlx_subparser.add_argument('bitstream', type=pathlib.PurePath, help="bitstream file")
19221921
xlx_subparser.set_defaults(func=ClientSession.xlx_program_bitstream)
19231922

19241923
xlx_subparser = xlx_subparsers.add_parser('boot', help='force boot mode and reset device')
1925-
xlx_subparser.add_argument('-r,', '--resource', help="resource name")
19261924
xlx_subparser.add_argument('bootmode', type=str, help="Boot mode to select (jtag, sd, qsmi, emmc, usb")
19271925
xlx_subparser.set_defaults(func=ClientSession.xlx_force_bootmode)
19281926

19291927
subparser = subparsers.add_parser('intel', help="connect to a Quartus Jtagd Server")
1928+
subparser.add_argument("--name", "-n", help="optional resource name")
19301929
subparser.set_defaults(func=lambda _: subparser.print_help())
19311930

19321931
intel_subparsers = subparser.add_subparsers(
@@ -1936,7 +1935,6 @@ def main():
19361935
)
19371936

19381937
intel_subparser = intel_subparsers.add_parser('program-bitstream', help="program bitstream")
1939-
intel_subparser.add_argument('-r,', '--resource', help="resource name")
19401938
intel_subparser.add_argument('bitstream', type=pathlib.PurePath, help="bitstream file")
19411939
intel_subparser.set_defaults(func=ClientSession.intel_program_bitstream)
19421940

0 commit comments

Comments
 (0)