non-top-level imports

Author: abeglova

channels/apps.py

@@ -12,5 +12,5 @@ def ready(self):
         """
         Ready handler. Import signals.
         """
-        import channels.signals  # noqa: F401
-        from channels import schema  # noqa: F401
+        import channels.signals  # noqa: F401,PLC0415
+        from channels import schema  # noqa: F401,PLC0415

learning_resources/apps.py

@@ -12,4 +12,4 @@ class LearningResourcesConfig(AppConfig):
     hookspec = HookspecMarker(name)
 
     def ready(self):
-        from learning_resources import schema  # noqa: F401
+        from learning_resources import schema  # noqa: F401,PLC0415

learning_resources/etl/canvas.py

@@ -8,6 +8,7 @@
 
 from learning_resources.constants import LearningResourceType
 from learning_resources.etl.constants import ETLSource
+from learning_resources.etl.loaders import load_content_files
 from learning_resources.etl.utils import _process_olx_path, calc_checksum
 from learning_resources.models import LearningResource, LearningResourceRun
 
@@ -18,8 +19,6 @@ def sync_canvas_archive(bucket, key: str, overwrite):
     """
     Sync a Canvas course archive from S3
     """
-    from learning_resources.etl.loaders import load_content_files
-
     with TemporaryDirectory() as export_tempdir:
         course_archive_path = Path(export_tempdir, key.split("/")[-1])
         bucket.download_file(key, course_archive_path)

learning_resources/models.py

@@ -13,6 +13,7 @@
 from django.db.models.functions import Lower
 from django.utils import timezone
 
+from channels.models import Channel
 from learning_resources import constants
 from learning_resources.constants import (
     Availability,
@@ -69,8 +70,6 @@ def for_serialization(self):
 
     def annotate_channel_url(self):
         """Annotate with the channel url"""
-        from channels.models import Channel
-
         return self.annotate(
             channel_url=(
                 Channel.objects.filter(topic_detail__topic=OuterRef("pk"))
@@ -135,8 +134,6 @@ def for_serialization(self):
 
     def annotate_channel_url(self):
         """Annotate with the channel url"""
-        from channels.models import Channel
-
         return self.annotate(
             channel_url=(
                 Channel.objects.filter(unit_detail__unit=OuterRef("pk"))
@@ -253,8 +250,6 @@ def for_serialization(self, *, prefetch_school: bool = False):
 
     def annotate_channel_url(self):
         """Annotate the queryset with channel_url"""
-        from channels.models import Channel
-
         return self.annotate(
             channel_url=(
                 Channel.objects.filter(department_detail__department=OuterRef("pk"))
@@ -281,8 +276,6 @@ class LearningResourceDepartment(TimestampedModel):
     @cached_property
     def channel_url(self) -> str | None:
         """Get the channel url for the department if it exists"""
-        from channels.models import Channel
-
         channel = Channel.objects.filter(department_detail__department=self).first()
         return channel.channel_url if channel is not None else None
 

learning_resources/views_test.py

@@ -37,6 +37,7 @@
     VideoPlaylistFactory,
 )
 from learning_resources.models import (
+    LearningResource,
     LearningResourceOfferor,
     LearningResourceRelationship,
     PodcastEpisode,
@@ -54,6 +55,7 @@
     VideoResourceSerializer,
     VideoSerializer,
 )
+from learning_resources.views import CourseViewSet
 from learning_resources_search.api import Search
 from learning_resources_search.serializers import serialize_learning_resource_for_update
 
@@ -209,7 +211,6 @@ def test_no_excess_queries(rf, user, mocker, django_assert_num_queries, course_c
     There should be a constant number of queries made (based on number of
     related models), regardless of number of results returned.
     """
-    from learning_resources.views import CourseViewSet
 
     CourseFactory.create_batch(course_count)
 
@@ -1092,8 +1093,6 @@ def test_featured_view_filter(client, offeror_featured_lists, parameter):
 
 def test_similar_resources_endpoint_does_not_return_self(mocker, client):
     """Test similar learning_resources endpoint does not return initial resource"""
-    from learning_resources.models import LearningResource
-
     resources = LearningResourceFactory.create_batch(5)
 
     resource_ids = [learning_resource.id for learning_resource in resources]
@@ -1127,8 +1126,6 @@ def test_similar_resources_endpoint_does_not_return_self(mocker, client):
 
 def test_similar_resources_endpoint_only_returns_published(mocker, client):
     """Test similar learning_resources endpoint only returns published items"""
-    from learning_resources.models import LearningResource
-
     resources = LearningResourceFactory.create_batch(5)
 
     resource_ids = [learning_resource.id for learning_resource in resources]
@@ -1170,8 +1167,6 @@ def test_similar_resources_endpoint_only_returns_published(mocker, client):
 
 def test_similar_resources_endpoint_ignores_opensearch_published(mocker, client):
     """Test similar learning_resources ignores the published attribute from opensearch"""
-    from learning_resources.models import LearningResource
-
     resources = LearningResourceFactory.create_batch(5)
 
     resource_ids = [learning_resource.id for learning_resource in resources]
@@ -1209,8 +1204,6 @@ def test_similar_resources_endpoint_ignores_opensearch_published(mocker, client)
 
 def test_vector_similar_resources_endpoint_does_not_return_self(mocker, client):
     """Test vector based similar resources endpoint does not return initial id"""
-    from learning_resources.models import LearningResource
-
     resources = LearningResourceFactory.create_batch(5)
 
     resource_ids = [learning_resource.id for learning_resource in resources]
@@ -1241,8 +1234,6 @@ def test_vector_similar_resources_endpoint_does_not_return_self(mocker, client):
 
 def test_vector_similar_resources_endpoint_only_returns_published(mocker, client):
     """Test vector based similar resources endpoint only returns published items"""
-    from learning_resources.models import LearningResource
-
     resources = LearningResourceFactory.create_batch(5)
 
     resource_ids = [learning_resource.id for learning_resource in resources]
@@ -1279,8 +1270,6 @@ def test_vector_similar_resources_endpoint_only_returns_published(mocker, client
 
 def test_learning_resources_display_info_list_view(mocker, client):
     """Test learning_resources_display_info_list_view returns expected results"""
-    from learning_resources.models import LearningResource
-
     LearningResource.objects.all().delete()
     resources = LearningResourceFactory.create_batch(
         5, published=True, title="test_learning_resources_display_info_list_view"
@@ -1309,8 +1298,6 @@ def test_learning_resources_display_info_list_view(mocker, client):
 
 def test_run_with_null_prices_does_not_throw_error(mocker, client):
     """Test learning_resources_display_info_detail_view does not throw exception"""
-    from learning_resources.models import LearningResource
-
     run = LearningResourceRunFactory.create(
         run_id="test",
         learning_resource=CourseFactory.create(
@@ -1338,8 +1325,6 @@ def test_run_with_null_prices_does_not_throw_error(mocker, client):
 
 def test_learning_resources_display_info_detail_view(mocker, client):
     """Test learning_resources_display_info_detail_view returns expected result"""
-    from learning_resources.models import LearningResource
-
     resource = LearningResource.objects.for_search_serialization().get(
         id=LearningResourceFactory.create().id
     )

learning_resources_search/api.py

@@ -36,6 +36,7 @@
     document_percolated_actions,
 )
 from vector_search.constants import RESOURCES_COLLECTION_NAME
+from vector_search.utils import dense_encoder, qdrant_client, vector_point_id
 
 log = logging.getLogger(__name__)
 
@@ -923,8 +924,6 @@ def _qdrant_similar_results(doc, num_resources):
         list of dict:
             list of serialized resources
     """
-    from vector_search.utils import dense_encoder, qdrant_client, vector_point_id
-
     encoder = dense_encoder()
     client = qdrant_client()
     return [