Skip to content

RGAT minor issues , listed in description #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkankana opened this issue Feb 21, 2025 · 2 comments
Closed

RGAT minor issues , listed in description #2126

mkankana opened this issue Feb 21, 2025 · 2 comments

Comments

@mkankana
Copy link

  1. audit file names audit.conf instead of audit.config causing issue with compliance test.I believe loadgen is looking for a file named audit.config.
    https://github.com/mlcommons/inference/blob/master/compliance/nvidia/TEST01/rgat/audit.conf
    Not a blocker , help appreciated.
  2. v5.0 not listed in submission_checker here, resulting in equal_issue_used_check failure.
@arjunsuresh
Copy link
Contributor

  1. The default expectation from loadgen is correct but we can use any filename and pass the file explicitly to the loadgen as in the reference implementation here. To avoid confusion I have created a PR here
  2. That's correct right? For v5.0 equal issue mode check is enabled. Previously it was not enabled due to a bug in the loadgen.

@mkankana
Copy link
Author

Thank you @arjunsuresh for clear explanation. We can close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants